v4 duplicate transactions non-segwit->segwit

[parazyd]

In testnet v4 I noticed duplicate transactions happening when sending coins from non-segwit addresses to segwit ones.
This also breaks balance fetch as it doubles up.

I can reproduce this when using both bx and zmq.

$ bx fetch-history c66eb3f4fb8b5613a4899b2d7351070f22386d345aaed3474af9fcf84a507bb9
transfers
{
    transfer
    {
        received
        {
            hash 74b945e0170735de9cbde60320680f1f28c05ef15ac3517e9443052592700a3b
            height 1972006
            index 0
        }
        value 1953337
    }
    transfer
    {
        received
        {
            hash 74b945e0170735de9cbde60320680f1f28c05ef15ac3517e9443052592700a3b
            height 1972006
            index 0
        }
        value 1953337
    }
}

$ bx fetch-balance c66eb3f4fb8b5613a4899b2d7351070f22386d345aaed3474af9fcf84a507bb9
balance
{
    key c66eb3f4fb8b5613a4899b2d7351070f22386d345aaed3474af9fcf84a507bb9
    received 3906674
    spent 0
}

[evoskuil]

I don’t expect v4 server stack to be reliable for some time, but I’m working toward it full time presently. The new Electrum-style payment indexation is new and has never been sufficiently tested. You can try simply filtering out dups.

[parazyd]

Thanks. Yes, I was already filtering duplicates, and that seems fine as a stop-gap solution. Just thought it made sense to have this bug noted down and kept in mind :)