Fix bad map lookup

We need to be checking for undefined
when looking up values in logLineIdxToVisualIdx
and cLineIdToVisualIdx as 0 can be returned,
which is a valid index.

Author: jordalgo

src/App.tsx

@@ -279,10 +279,11 @@ function App() {
         if (logLines && logLines.size > 0) {
           [logLineId] = logLines;
         }
+        const visualLogLineIdx = logLineIdxToVisualIdx.get(logLineId);
         setSelectedAndScroll(
           logLineId,
           cLines[nextVisibleIdx],
-          logLineIdxToVisualIdx.get(logLineId) || -1,
+          visualLogLineIdx === undefined ? -1 : visualLogLineIdx,
           nextVisibleIdx,
         );
       } else {
@@ -296,11 +297,12 @@ function App() {
         const logLineId = logLines[nextInsVisualIdx].idx;
         const cLineId =
           verifierLogState.cSourceMap.logLineToCLine.get(logLineId) || "";
+        const visualCLineIdx = cLineIdToVisualIdx.get(cLineId);
         setSelectedAndScroll(
           logLineId,
           "",
           nextInsVisualIdx,
-          cLineIdToVisualIdx.get(cLineId) || -1,
+          visualCLineIdx === undefined ? -1 : visualCLineIdx,
         );
       }
     };
@@ -481,11 +483,12 @@ function App() {
           parsedLine.type == ParsedLineType.C_SOURCE
             ? parsedLine.id
             : verifierLogState.cSourceMap.logLineToCLine.get(lineId) || "";
+        const visualCLineIdx = cLineIdToVisualIdx.get(clineId);
         setSelectedAndScroll(
           lineId,
           "",
           -1,
-          cLineIdToVisualIdx.get(clineId) || -1,
+          visualCLineIdx === undefined ? -1 : visualCLineIdx,
           memSlotId,
         );
       }

src/components.tsx

@@ -1137,7 +1137,7 @@ export function MainContent({
 
     if (shouldScrollLogLines) {
       const visualIdx = logLineIdxToVisualIdx.get(maxIdx);
-      if (visualIdx) {
+      if (visualIdx !== undefined) {
         scrollToLogLine(visualIdx, logLines.length);
       }
     }
@@ -1204,7 +1204,7 @@ export function MainContent({
   const handleStateLogLineClick = useCallback(
     (e: React.MouseEvent<HTMLDivElement>) => {
       const visualIdx = logLineIdxToVisualIdx.get(selectedLine);
-      if (visualIdx) {
+      if (visualIdx !== undefined) {
         scrollToLogLine(visualIdx, logLines.length);
       }
       e.stopPropagation();
@@ -1218,7 +1218,7 @@ export function MainContent({
         verifierLogState.cSourceMap.logLineToCLine.get(selectedLine);
       if (cLineId) {
         const cLineIdx = cLineIdToVisualIdx.get(cLineId);
-        if (cLineIdx) {
+        if (cLineIdx !== undefined) {
           scrollToCLine(cLineIdx, cLines.length);
         }
       }