Skip to content

Add xxd to the base CI debian image #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sinkap wants to merge 1 commit into from
Closed

Add xxd to the base CI debian image #192

sinkap wants to merge 1 commit into from

Conversation

@sinkap
Copy link
Contributor

@sinkap sinkap commented Jul 14, 2025

xxd is used to generate a C header from a verification certificate (DER encoded) which is used to test BPF signing infrastructure in selftests.

@sinkap
Add xxd to the base CI debian Image
8fba5bb 
xxd is used to generate a C header from a verification certificate (DER encoded) which is used to test BPF signing infrastructure in selftests.
@sinkap sinkap changed the title Add xxd to the base CI debian Image Add xxd to the base CI debian image Jul 14, 2025
@borkmann borkmann requested a review from chantra July 14, 2025 17:50
@theihor
Copy link
Contributor

theihor commented Jul 14, 2025

@sinkap rootfs is not used by BPF CI (anymore). If xxd is a requirement for relevant BPF selftests, you need to add the package here: https://github.com/libbpf/ci/blob/main/run-vmtest/install-dependencies.sh#L11-L12

I know it's confusing, sorry :/

@theihor theihor requested review from theihor and removed request for chantra July 14, 2025 18:08
theihor
theihor requested changes Jul 14, 2025
View reviewed changes
Copy link
Contributor

@theihor theihor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just looked at your patch: https://lore.kernel.org/bpf/20250606232914.317094-13-kpsingh@kernel.org/

So xxd is required at selftests build time, not run time. Which means that the proper place for this dependency is https://github.com/libbpf/ci/blob/main/setup-build-env/install_packages.sh#L15-L20

I wonder if there is a way to generate that header without an additional dependency?

@sinkap
Copy link
Contributor Author

sinkap commented Jul 14, 2025 •
edited
Loading

I did not find an easy way to generate the header without xxd, it will be ugly and fragile, let's just use xxd.

I sent #193

@sinkap sinkap closed this Jul 14, 2025
@theihor theihor mentioned this pull request Jul 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theihor theihor theihor requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sinkap @theihor