Open README with write permissions #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evidently, some file systems require write permissions in order to lock a file or locking will fail. Open the README file, which we use for locking purposes, with write permissions in an attempt to make locking work on all file systems that the crate may be built on. Closes: libbpf#116 Signed-off-by: Daniel Müller <[email protected]>
Collaborator
Author
|
I guess this could potentially blow up on a read-only file system, which also isn't great... |
Collaborator
Author
Added a fallback now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evidently, some file systems require write permissions in order to lock a file or locking will fail. Open the README file, which we use for locking purposes, with write permissions in an attempt to make locking work on all file systems that the crate may be built on.
Closes: #116