Clang Tidy path hint while searching for program.

Cppcheck path hint while searching for program.
Fixups/suppressions for clang-tidy checks.
Suppressions for cppcheck-s.

Author: T-Maxxx

cmake/clang-tidy.cmake

@@ -1,13 +1,16 @@
+# Include this file if and only if you want to use clang-tidy linter.
+
 if (NOT ${CMAKE_SYSTEM_NAME} STREQUAL "Windows")
-    find_program(CLANG_TIDY_EXECUTABLE NAMES clang-tidy)
+    if (NOT ${CPR_LINTER_PATH} STREQUAL "")
+        get_filename_component(CLANG_TIDY_HINT_FILENAME ${CPR_LINTER_PATH} NAME)
+        get_filename_component(CLANG_TIDY_HINT_PATH ${CPR_LINTER_PATH} DIRECTORY)
+    endif ()
+
+    find_program(CLANG_TIDY_EXECUTABLE NAMES clang-tidy ${CLANG_TIDY_HINT_FILENAME} HINTS ${CLANG_TIDY_HINT_PATH} REQUIRED)
     mark_as_advanced(CLANG_TIDY_EXECUTABLE)
 
-    if (${CLANG_TIDY_EXECUTABLE})
-        message(FATAL_ERROR "Clang-tidy not found")
-    else()
-        message(STATUS "Enabling clang-tidy")
-        set(CMAKE_CXX_CLANG_TIDY "${CLANG_TIDY_EXECUTABLE};-warnings-as-errors=*")
-    endif()
-else()
+    message(STATUS "Enabling clang-tidy: ${CLANG_TIDY_EXECUTABLE}")
+    set(CMAKE_CXX_CLANG_TIDY "${CLANG_TIDY_EXECUTABLE};-warnings-as-errors=*")
+else ()
     message(FATAL_ERROR "Clang-tidy is not supported when building for windows")
-endif()
+endif ()

cmake/cppcheck.cmake

@@ -1,7 +1,15 @@
-find_program(CMAKE_CXX_CPPCHECK NAMES cppcheck)
+# Include this file if and only if you want to use cppcheck.
 
-if(CMAKE_CXX_CPPCHECK)
-    list(APPEND CMAKE_CXX_CPPCHECK "--xml"
+if (NOT ${CPR_CPPCHECK_PATH} STREQUAL "")
+    get_filename_component(CPPCHECK_HINT_FILENAME ${CPR_CPPCHECK_PATH} NAME)
+    get_filename_component(CPPCHECK_HINT_PATH ${CPR_CPPCHECK_PATH} DIRECTORY)
+endif ()
+
+find_program(CMAKE_CXX_CPPCHECK NAMES cppcheck ${CPPCHECK_HINT_FILENAME} HINTS ${CPPCHECK_HINT_PATH} REQUIRED)
+message(STATUS "Found cppcheck: ${CMAKE_CXX_CPPCHECK}")
+
+list(APPEND CMAKE_CXX_CPPCHECK
+        "--xml"
         "--error-exitcode=1"
         "--enable=warning,style"
         "--force"
@@ -11,5 +19,5 @@ if(CMAKE_CXX_CPPCHECK)
         "--cppcheck-build-dir=${PROJECT_BINARY_DIR}"
         "--suppress-xml=${PROJECT_SOURCE_DIR}/cppcheck-suppressions.xml"
         "--output-file=${PROJECT_BINARY_DIR}/cppcheck.xml"
-        "--check-level=normal")
-endif()
+        "--check-level=normal"
+)

cppcheck-suppressions.xml

@@ -24,6 +24,11 @@
         <id>y2038-unsafe-call</id>
         <fileName>*/include/cpr/low_speed.h</fileName>
     </suppress>
+    <!-- No reason to check third party includes -->
+    <suppress>
+        <id>y2038-unsafe-call</id>
+        <fileName>*/curl/curl.h</fileName>
+    </suppress>
     <suppress>
         <id>normalCheckLevelMaxBranches</id>
     </suppress>

cpr/session.cpp

@@ -12,6 +12,8 @@
 #include <optional>
 #include <stdexcept>
 #include <string>
+#include <string_view>
+#include <type_traits>
 #include <utility>
 #include <variant>
 #include <vector>
@@ -26,6 +28,7 @@
 #include "cpr/auth.h"
 #include "cpr/bearer.h"
 #include "cpr/body.h"
+#include "cpr/body_view.h"
 #include "cpr/callback.h"
 #include "cpr/connect_timeout.h"
 #include "cpr/cookies.h"
@@ -492,6 +495,7 @@ void Session::SetBody(Body&& body) {
     content_ = std::move(body);
 }
 
+// cppcheck-suppress passedByValue
 void Session::SetBodyView(BodyView body) {
     static_assert(std::is_trivially_copyable_v<BodyView>, "BodyView expected to be trivially copyable otherwise will need some std::move across codebase");
     content_ = body;
@@ -983,6 +987,7 @@ void Session::prepareBodyPayloadOrMultipart() const {
     } else if (std::holds_alternative<cpr::BodyView>(content_)) {
         const std::string_view body = std::get<cpr::BodyView>(content_).str();
         curl_easy_setopt(curl_->handle, CURLOPT_POSTFIELDSIZE_LARGE, static_cast<curl_off_t>(body.length()));
+        // NOLINTNEXTLINE (bugprone-suspicious-stringview-data-usage)
         curl_easy_setopt(curl_->handle, CURLOPT_POSTFIELDS, body.data());
     } else if (std::holds_alternative<cpr::Multipart>(content_)) {
         // Make sure, we have a empty multipart to start with:
@@ -1070,6 +1075,7 @@ void Session::SetOption(const Redirect& redirect) { SetRedirect(redirect); }
 void Session::SetOption(const Cookies& cookies) { SetCookies(cookies); }
 void Session::SetOption(const Body& body) { SetBody(body); }
 void Session::SetOption(Body&& body) { SetBody(std::move(body)); }
+// cppcheck-suppress passedByValue
 void Session::SetOption(BodyView body) { SetBodyView(body); }
 void Session::SetOption(const LowSpeed& low_speed) { SetLowSpeed(low_speed); }
 void Session::SetOption(const VerifySsl& verify) { SetVerifySsl(verify); }