Skip to content
This repository was archived by the owner on Nov 21, 2019. It is now read-only.

Commit 339396c

Browse files
nlisgothewilkybarkid
nlisgo
authored and
thewilkybarkid
committed
Subscript libero (#46)
* Add support for sub in JatsContentBundle * Update patterns * Introduce patterns at the moment that sub template was merged * Update vendor-extra/JatsContentBundle/src/Resources/config/services.xml Co-Authored-By: nlisgo <[email protected]> * Add support for subscript with libero xml * Update vendor-extra/LiberoContentBundle/tests/ViewConverter/SubVisitorTest.php Co-Authored-By: nlisgo <[email protected]>
1 parent 239f82e commit 339396c

File tree

3 files changed

+168
-1
lines changed

3 files changed

+168
-1
lines changed

‎vendor-extra/LiberoContentBundle/src/Resources/config/services.xml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,14 @@
3838
<tag name="libero.view_converter"/>
3939
</service>
4040

41+
<service id="Libero\LiberoContentBundle\ViewConverter\SubVisitor"
42+
class="Libero\LiberoContentBundle\ViewConverter\SubVisitor">
43+
<argument type="service" id="Libero\ViewsBundle\Views\ViewConverter"/>
44+
<tag name="libero.view_converter"/>
45+
</service>
46+
4147
<service id="Libero\LiberoContentBundle\ViewConverter\SupVisitor"
42-
class="Libero\LiberoContentBundle\ViewConverter\SupVisitor">
48+
class="Libero\LiberoContentBundle\ViewConverter\SupVisitor">
4349
<argument type="service" id="Libero\ViewsBundle\Views\ViewConverter"/>
4450
<tag name="libero.view_converter"/>
4551
</service>

‎vendor-extra/LiberoContentBundle/src/ViewConverter/SubVisitor.php

Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
1+
<?php
2+
3+
declare(strict_types=1);
4+
5+
namespace Libero\LiberoContentBundle\ViewConverter;
6+
7+
use FluentDOM\DOM\Element;
8+
use Libero\ViewsBundle\Views\ConvertsChildren;
9+
use Libero\ViewsBundle\Views\SimplifiedChildVisitor;
10+
use Libero\ViewsBundle\Views\View;
11+
use Libero\ViewsBundle\Views\ViewConverter;
12+
use Libero\ViewsBundle\Views\ViewConverterVisitor;
13+
14+
final class SubVisitor implements ViewConverterVisitor
15+
{
16+
use ConvertsChildren;
17+
use SimplifiedChildVisitor;
18+
19+
private $converter;
20+
21+
public function __construct(ViewConverter $converter)
22+
{
23+
$this->converter = $converter;
24+
}
25+
26+
protected function doVisit(Element $object, View $view, array &$context = []) : View
27+
{
28+
return $view->withArgument('text', $this->convertChildren($object, $context));
29+
}
30+
31+
protected function possibleTemplate() : string
32+
{
33+
return '@LiberoPatterns/sub.html.twig';
34+
}
35+
36+
protected function expectedElement() : string
37+
{
38+
return '{http://libero.pub}sub';
39+
}
40+
41+
protected function unexpectedArguments() : array
42+
{
43+
return ['text'];
44+
}
45+
}

‎vendor-extra/LiberoContentBundle/tests/ViewConverter/SubVisitorTest.php

Lines changed: 116 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,116 @@
1+
<?php
2+
3+
declare(strict_types=1);
4+
5+
namespace tests\Libero\LiberoContentBundle\ViewConverter;
6+
7+
use Libero\LiberoContentBundle\ViewConverter\SubVisitor;
8+
use Libero\ViewsBundle\Views\View;
9+
use PHPUnit\Framework\TestCase;
10+
use tests\Libero\ContentPageBundle\ViewConvertingTestCase;
11+
use tests\Libero\ContentPageBundle\XmlTestCase;
12+
13+
final class SubVisitorTest extends TestCase
14+
{
15+
use ViewConvertingTestCase;
16+
use XmlTestCase;
17+
18+
/**
19+
* @test
20+
* @dataProvider nodeProvider
21+
*/
22+
public function it_does_nothing_if_it_is_not_a_libero_sub_element(string $xml) : void
23+
{
24+
$visitor = new SubVisitor($this->createFailingConverter());
25+
26+
$element = $this->loadElement($xml);
27+
28+
$newContext = [];
29+
$view = $visitor->visit($element, new View(null), $newContext);
30+
31+
$this->assertNull($view->getTemplate());
32+
$this->assertEmpty($view->getArguments());
33+
$this->assertEmpty($newContext);
34+
}
35+
36+
public function nodeProvider() : iterable
37+
{
38+
yield 'different namespace' => ['<sub xmlns="http://example.com">foo</sub>'];
39+
yield 'different element' => ['<italic xmlns="http://libero.pub">foo</italic>'];
40+
}
41+
42+
/**
43+
* @test
44+
*/
45+
public function it_does_nothing_if_is_not_the_sub_template() : void
46+
{
47+
$visitor = new SubVisitor($this->createFailingConverter());
48+
49+
$element = $this->loadElement('<sub xmlns="http://libero.pub">foo</sub>');
50+
51+
$newContext = [];
52+
$view = $visitor->visit($element, new View('template'), $newContext);
53+
54+
$this->assertSame('template', $view->getTemplate());
55+
$this->assertEmpty($view->getArguments());
56+
$this->assertEmpty($newContext);
57+
}
58+
59+
/**
60+
* @test
61+
*/
62+
public function it_does_nothing_if_there_is_already_text_set() : void
63+
{
64+
$visitor = new SubVisitor($this->createFailingConverter());
65+
66+
$element = $this->loadElement('<sub xmlns="http://libero.pub">foo</sub>');
67+
68+
$newContext = [];
69+
$view = $visitor->visit($element, new View(null, ['text' => 'bar']), $newContext);
70+
71+
$this->assertNull($view->getTemplate());
72+
$this->assertSame(['text' => 'bar'], $view->getArguments());
73+
$this->assertEmpty($newContext);
74+
}
75+
76+
/**
77+
* @test
78+
*/
79+
public function it_sets_the_template_and_text_argument() : void
80+
{
81+
$visitor = new SubVisitor($this->createDumpingConverter());
82+
83+
$element = $this->loadElement(
84+
<<<XML
85+
<libero:sub xmlns:libero="http://libero.pub">
86+
foo <libero:bold>bar</libero:bold> baz
87+
</libero:sub>
88+
XML
89+
);
90+
91+
$newContext = ['qux' => 'quux'];
92+
$view = $visitor->visit($element, new View(null), $newContext);
93+
94+
$this->assertSame('@LiberoPatterns/sub.html.twig', $view->getTemplate());
95+
$this->assertEquals(
96+
[
97+
'text' => [
98+
new View(
99+
null,
100+
['node' => '/libero:sub/text()[1]', 'template' => null, 'context' => ['qux' => 'quux']]
101+
),
102+
new View(
103+
null,
104+
['node' => '/libero:sub/libero:bold', 'template' => null, 'context' => ['qux' => 'quux']]
105+
),
106+
new View(
107+
null,
108+
['node' => '/libero:sub/text()[2]', 'template' => null, 'context' => ['qux' => 'quux']]
109+
),
110+
],
111+
],
112+
$view->getArguments()
113+
);
114+
$this->assertSame(['qux' => 'quux'], $newContext);
115+
}
116+
}

0 commit comments

Comments
 (0)