Use PHPStan 0.11 (#40)

Author: thewilkybarkid

composer.json

@@ -47,9 +47,9 @@
         "csa/guzzle-cache-middleware": "^1.0",
         "libero/coding-standard": "^0.3",
         "php-vfs/php-vfs": "^1.4",
-        "phpstan/phpstan": "^0.10",
-        "phpstan/phpstan-phpunit": "^0.10",
-        "phpstan/phpstan-symfony": "^0.10",
+        "phpstan/phpstan": "^0.11",
+        "phpstan/phpstan-phpunit": "^0.11",
+        "phpstan/phpstan-symfony": "^0.11",
         "phpunit/phpunit": "^7.4",
         "psr/http-message": "^1.0",
         "symfony/browser-kit": "^4.1",

composer.lock

@@ -3,7 +3,6 @@ parameters:
         - '~^Call to an undefined method FluentDOM\\DOM\\Node\\.+?::getNodePath\(\)\.$~'
         - '~^Cannot cast FluentDOM\\DOM\\Node\\.+? to string\.$~'
         - '~^Cannot call method ([a-z]+)Node\(\) on Symfony\\Component\\Config\\Definition\\Builder\\NodeParentInterface\|null\.$~'
-        - '~^Method [^\s]+? should return FluentDOM\\DOM\\Element but returns DOMElement\.$~'
         - '~^Service "csa_guzzle\.mock\.storage" is not registered in the container\.$~'
     level: max
     paths:

phpstan.neon.dist

@@ -4,7 +4,6 @@
 
 namespace Libero\JatsContentBundle\ViewConverter;
 
-use FluentDOM\DOM\Document;
 use FluentDOM\DOM\Element;
 use Libero\ViewsBundle\Views\SimplifiedVisitor;
 use Libero\ViewsBundle\Views\View;
@@ -24,10 +23,8 @@ public function __construct(ViewConverter $converter)
 
     protected function doVisit(Element $object, View $view, array &$context = []) : View
     {
-        /** @var Document $document */
-        $document = $object->ownerDocument;
-
-        $title = $document->xpath()->firstOf('jats:article-meta/jats:title-group/jats:article-title', $object);
+        $title = $object->ownerDocument->xpath()
+            ->firstOf('jats:article-meta/jats:title-group/jats:article-title', $object);
 
         if (!$title instanceof Element) {
             return $view;

vendor-extra/JatsContentBundle/src/ViewConverter/FrontArticleTitleContentHeaderVisitor.php

@@ -5,7 +5,6 @@
 namespace Libero\JatsContentBundle\ViewConverter;
 
 use DOMNodeList;
-use FluentDOM\DOM\Document;
 use FluentDOM\DOM\Element;
 use Libero\ViewsBundle\Views\ConvertsLists;
 use Libero\ViewsBundle\Views\SimplifiedVisitor;
@@ -27,11 +26,9 @@ public function __construct(ViewConverter $converter)
 
     protected function doVisit(Element $object, View $view, array &$context = []) : View
     {
-        /** @var Document $document */
-        $document = $object->ownerDocument;
-
         /** @var DOMNodeList|Element[] $keywordGroups */
-        $keywordGroups = $document->xpath()->evaluate('jats:article-meta/jats:kwd-group[@kwd-group-type]', $object);
+        $keywordGroups = $object->ownerDocument->xpath()
+            ->evaluate('jats:article-meta/jats:kwd-group[@kwd-group-type]', $object);
 
         if (0 === count($keywordGroups)) {
             return $view;

vendor-extra/JatsContentBundle/src/ViewConverter/FrontItemTagsVisitor.php

@@ -5,7 +5,6 @@
 namespace Libero\JatsContentBundle\ViewConverter;
 
 use DOMNodeList;
-use FluentDOM\DOM\Document;
 use FluentDOM\DOM\Element;
 use Libero\ViewsBundle\Views\ConvertsLists;
 use Libero\ViewsBundle\Views\SimplifiedVisitor;
@@ -34,11 +33,8 @@ public function __construct(ViewConverter $converter, TranslatorInterface $trans
 
     protected function doVisit(Element $object, View $view, array &$context = []) : View
     {
-        /** @var Document $document */
-        $document = $object->ownerDocument;
-
         /** @var DOMNodeList|Element[] $subjects */
-        $subjects = $document->xpath()->evaluate(
+        $subjects = $object->ownerDocument->xpath()->evaluate(
             'jats:article-meta/jats:article-categories/jats:subj-group[@subj-group-type="heading"]/jats:subject',
             $object
         );

vendor-extra/JatsContentBundle/src/ViewConverter/FrontSubjectGroupContentHeaderVisitor.php

@@ -5,7 +5,6 @@
 namespace Libero\JatsContentBundle\ViewConverter;
 
 use DOMNodeList;
-use FluentDOM\DOM\Document;
 use FluentDOM\DOM\Element;
 use Libero\ViewsBundle\Views\ConvertsLists;
 use Libero\ViewsBundle\Views\SimplifiedVisitor;
@@ -34,10 +33,8 @@ public function __construct(ViewConverter $converter, TranslatorInterface $trans
 
     protected function doVisit(Element $object, View $view, array &$context = []) : View
     {
-        /** @var Document $document */
-        $document = $object->ownerDocument;
-
-        $title = $document->xpath()->firstOf('jats:title', $object);
+        $title = $object->ownerDocument->xpath()
+            ->firstOf('jats:title', $object);
 
         /** @var DOMNodeList|Element[] $keywords */
         $keywords = $object('jats:kwd');

vendor-extra/JatsContentBundle/src/ViewConverter/KeywordGroupTagListVisitor.php

@@ -5,7 +5,6 @@
 namespace Libero\JatsContentBundle\ViewConverter;
 
 use DOMNodeList;
-use FluentDOM\DOM\Document;
 use FluentDOM\DOM\Element;
 use FluentDOM\DOM\Node\NonDocumentTypeChildNode;
 use Libero\ViewsBundle\Views\ConvertsChildren;
@@ -32,10 +31,8 @@ protected function doVisit(Element $object, View $view, array &$context = []) :
     {
         $context['level'] = $context['level'] ?? 1;
 
-        /** @var Document $document */
-        $document = $object->ownerDocument;
-
-        $heading = $document->xpath()->firstOf('jats:title', $object);
+        $heading = $object->ownerDocument->xpath()
+            ->firstOf('jats:title', $object);
 
         if ($heading instanceof Element) {
             $view = $view->withArgument(

vendor-extra/JatsContentBundle/src/ViewConverter/SectionVisitor.php

@@ -4,7 +4,6 @@
 
 namespace tests\Libero\JatsContentBundle\EventListener;
 
-use FluentDOM\DOM\Document;
 use Libero\ContentPageBundle\Event\CreateContentPageEvent;
 use Libero\JatsContentBundle\EventListener\ItemTagsListener;
 use Libero\ViewsBundle\Views\View;
@@ -24,7 +23,6 @@ public function it_does_nothing_if_it_does_not_find_the_front() : void
     {
         $listener = new ItemTagsListener($this->createFailingConverter());
 
-        /** @var Document $document */
         $document = $this->loadDocument(
             <<<XML
 <?xml version="1.0" encoding="UTF-8"?>

vendor-extra/JatsContentBundle/tests/EventListener/ItemTagsListenerTest.php

@@ -4,7 +4,6 @@
 
 namespace Libero\LiberoContentBundle\ViewConverter;
 
-use FluentDOM\DOM\Document;
 use FluentDOM\DOM\Element;
 use Libero\ViewsBundle\Views\SimplifiedVisitor;
 use Libero\ViewsBundle\Views\View;
@@ -24,10 +23,8 @@ public function __construct(ViewConverter $converter)
 
     protected function doVisit(Element $object, View $view, array &$context = []) : View
     {
-        /** @var Document $document */
-        $document = $object->ownerDocument;
-
-        $title = $document->xpath()->firstOf('libero:title[1]', $object);
+        $title = $object->ownerDocument->xpath()
+            ->firstOf('libero:title[1]', $object);
 
         if (!$title instanceof Element) {
             return $view;