Address code review feedback - optimize caching and remove duplicates

Co-authored-by: delicatacurtis <247246500+delicatacurtis@users.noreply.github.com>

Author: Copilot

.dockerignore

@@ -9,7 +9,6 @@
 docs/
 DEVELOPER_NOTES.md
 ARCHITECTURE.md
-*.md
 
 # CI/CD
 .circleci

.github/workflows/security.yml

@@ -76,6 +76,19 @@ jobs:
         with:
           php-version: '8.5'
           extensions: mbstring, bcmath, pdo, mysql, dom, curl
+
+      - name: Get Composer cache directory
+        id: composer-cache
+        run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
+
+      - name: Cache Composer dependencies
+        uses: actions/cache@v4
+        with:
+          path: ${{ steps.composer-cache.outputs.dir }}
+          key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-composer-
+
       - name: 'Run php-insight'
         run: |
           PHP_SC_VERSION=$(curl -s "https://api.github.com/repos/fabpot/local-php-security-checker/releases/latest" | grep '"tag_name":' | sed -E 's/.*"([^"]+)".*/\1/;s/^v//')

Dockerfile

@@ -119,6 +119,13 @@ COPY --from=composer:latest /usr/bin/composer /usr/bin/composer
 # Copy vendor from composer-deps stage for better caching
 COPY --chown=${USER}:${USER} --from=composer-deps /app/vendor ./vendor
 
+# Copy composer files (needed for autoloader generation)
+COPY --chown=${USER}:${USER} composer.json composer.lock ./
+
+# Generate optimized autoloader with vendor already in place
+RUN composer dump-autoload --classmap-authoritative --no-dev && \
+    composer clear-cache
+
 # Copy application code
 COPY --chown=${USER}:${USER} . .
 
@@ -139,10 +146,6 @@ COPY --chown=${USER}:${USER} .docker/supervisord.*.conf /etc/supervisor/conf.d/
 COPY --chown=${USER}:${USER} .docker/php.ini ${PHP_INI_DIR}/conf.d/99-octane.ini
 COPY --chown=${USER}:${USER} .docker/start-container /usr/local/bin/start-container
 
-# Generate optimized autoloader
-RUN composer dump-autoload --classmap-authoritative --no-dev && \
-    composer clear-cache
-
 # Copy environment file
 COPY --chown=${USER}:${USER} .env.example ./.env