Added getters for the free objects in the pooled engine.#315
Open
GadWissberg wants to merge 1 commit intolibgdx:masterfrom
Open
Added getters for the free objects in the pooled engine.#315GadWissberg wants to merge 1 commit intolibgdx:masterfrom
GadWissberg wants to merge 1 commit intolibgdx:masterfrom
Conversation
carlislefox
reviewed
Feb 20, 2026
| * @return Number of free objects in the given component type pool. | ||
| */ | ||
| public <T extends Component> int getComponentPoolFree(Class<T> componentType) { | ||
| return componentPools.pools.get(componentType).getFree(); |
Contributor
There was a problem hiding this comment.
This can throw a NullPointer should the componentType not be present in the pools.
Contributor
|
Hi Gad, no major concerns in principle however I would like to see the addition of a couple of tests that exercise the getComponentPoolFree() call to pick up cases such as requesting the number of objects in a pool that doesn't exist. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I want in my game to monitor the number of free objects in the pools - this is to make sure I don't have cases where calling "free()" is missed and thus leading to creating limitlessly new objects. I also wanted to monitor on the components and entities, but found out there's no access to the pools themseleves. So I added 2 getters.
Thanks in advance!