Conversation
|
Is there a problem for Lwjgl2 projects having both Lwjgl3 and 2 in the classpath? |
|
There's a problem for lwjgl2 projects having lwjgl2 on the classpath. But yeah, you can't have both 2 and 3, it will cause issues. |
|
Okay, I see the problem that people might not want to use Lwjgl3, but they can stick on older versions of libgdx and this library so this should not stop us. However, I caused some conflicts by merging your other PR which I eventually tested and is needed to make the build succeed. |
|
We should raise the version to 2.3.x (and make a 2.2.4 release) and add a new entry into the compatiblity matrix pointing out incompatibility with lwjgl2 projects. |
2a3bf76 to
403e304
Compare
403e304 to
b12b760
Compare
| gdxVersion = '1.13.1' | ||
| roboVMVersion = '2.3.19' | ||
| jamepadVersion = '2.26.5.0' | ||
| lwjgl3Version = '3.4.0-SNAPSHOT' |
There was a problem hiding this comment.
Is the snapshot version needed? Not good to have this library point to a snapshot
There was a problem hiding this comment.
For the moment yes, so I would only merge this after a stable lwjgl3 release exists.
There was a problem hiding this comment.
I believe the stable LWJGL version we're waiting on is available now, if you want to move forward with this.
MrStahlfelge
left a comment
There was a problem hiding this comment.
Probably 'test/desktop' can be removed - it should not work any more?
'test/ios' does not compile, it seems like there is a dependency problem. Probably RoboVM needs to get updated to the version 1.13.x uses
Yes, removed it.
A class was apparantly moved, fixed the import. I also upgraded roboVM in one go |
This PR removes the jampad dependency and uses the lwjgl3 SDL bindings instead.
Some classes from jampad have been moved over. I didn't saw the need for jampad being a seperate project anymore, as lwjgl3 provides the bindings now.
This PR depends on the
3.4.0-SNAPSHOTof lwjgl3.By accident, I applied similar fixes as done in this pr: #38
This pr is based of this pr: #39