NativeMethods: drop the CriticalFinalizerObject

ethomson · ethomson · commit b21e2f9e0ab6 · 2017-06-24T15:48:20.000+01:00
.NET Core no longer supports CriticalFinalizerObject. We now get the strictest finalization guarantees simply inheriting Object. See https://github.com/dotnet/corefx/issues/1345
diff --git a/LibGit2Sharp/Core/NativeMethods.cs b/LibGit2Sharp/Core/NativeMethods.cs
@@ -56,7 +56,7 @@ private static void LoadNativeLibrary()
         }
 
         // Shutdown the native library in a finalizer.
-        private sealed class NativeShutdownObject : CriticalFinalizerObject
+        private sealed class NativeShutdownObject
         {
             ~NativeShutdownObject()
             {

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ private static void LoadNativeLibrary()`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`// Shutdown the native library in a finalizer.`
`59`		`- private sealed class NativeShutdownObject : CriticalFinalizerObject`
	`59`	`+ private sealed class NativeShutdownObject`
`60`	`60`	`{`
`61`	`61`	`~NativeShutdownObject()`
`62`	`62`	`{`