Add and use StrArray.ptr()

To emphasize that the StrArray() context manager returns a pointer,
implement its ptr() property and use it whenever calling a C function
that takes a pointer to a git_strarray structure as a parameter.

Author: kempniu

pygit2/index.py

@@ -179,7 +179,7 @@ def remove(self, path, level=0):
     def remove_all(self, pathspecs):
         """Remove all index entries matching pathspecs."""
         with StrArray(pathspecs) as arr:
-            err = C.git_index_remove_all(self._index, arr, ffi.NULL, ffi.NULL)
+            err = C.git_index_remove_all(self._index, arr.ptr, ffi.NULL, ffi.NULL)
             check_error(err, io=True)
 
     def add_all(self, pathspecs=None):
@@ -190,7 +190,7 @@ def add_all(self, pathspecs=None):
         """
         pathspecs = pathspecs or []
         with StrArray(pathspecs) as arr:
-            err = C.git_index_add_all(self._index, arr, 0, ffi.NULL, ffi.NULL)
+            err = C.git_index_add_all(self._index, arr.ptr, 0, ffi.NULL, ffi.NULL)
             check_error(err, io=True)
 
     def add(self, path_or_entry):

pygit2/remotes.py

@@ -155,7 +155,7 @@ def fetch(
             opts.depth = depth
             self.__set_proxy(opts.proxy_opts, proxy)
             with StrArray(refspecs) as arr:
-                err = C.git_remote_fetch(self._remote, arr, opts, to_bytes(message))
+                err = C.git_remote_fetch(self._remote, arr.ptr, opts, to_bytes(message))
                 payload.check_error(err)
 
         return TransferProgress(C.git_remote_stats(self._remote))
@@ -263,7 +263,7 @@ def push(self, specs, callbacks=None, proxy=None):
             opts = payload.push_options
             self.__set_proxy(opts.proxy_opts, proxy)
             with StrArray(specs) as refspecs:
-                err = C.git_remote_push(self._remote, refspecs, opts)
+                err = C.git_remote_push(self._remote, refspecs.ptr, opts)
                 payload.check_error(err)
 
     def __set_proxy(self, proxy_opts, proxy):

pygit2/utils.py

@@ -92,7 +92,7 @@ class StrArray:
     list of strings. This has a context manager, which you should use, e.g.
 
         with StrArray(list_of_strings) as arr:
-            C.git_function_that_takes_strarray(arr)
+            C.git_function_that_takes_strarray(arr.ptr)
     """
 
     def __init__(self, l):
@@ -117,11 +117,15 @@ def __init__(self, l):
         self.array = ffi.new('git_strarray *', [self._arr, len(strings)])
 
     def __enter__(self):
-        return self.array
+        return self
 
     def __exit__(self, type, value, traceback):
         pass
 
+    @property
+    def ptr(self):
+        return self.array
+
 
 class GenericIterator:
     """Helper to easily implement an iterator.