improve types according to test/test_commit_gpg.py

Author: BenediktSeidl

pygit2/_pygit2.pyi

@@ -841,7 +841,7 @@ class Repository:
     def descendant_of(self, oid1: _OidArg, oid2: _OidArg) -> bool: ...
     def expand_id(self, hex: str) -> Oid: ...
     def free(self) -> None: ...
-    def get(self, key: str, default: Optional[Commit] = None) -> None | Object: ...
+    def get(self, key: _OidArg, default: Optional[Commit] = None) -> None | Object: ...
     def get_attr(
         self,
         path: str | bytes | Path,

pygit2/repository.py

@@ -202,7 +202,7 @@ def __iter__(self):
     #
     # Mapping interface
     #
-    def get(self, key: str, default: Optional[Commit] = None) -> Object:
+    def get(self, key: str | Oid, default: Optional[Commit] = None) -> Object:
         value = self.git_object_lookup_prefix(key)
         return value if (value is not None) else default
 

test/test_commit_gpg.py

@@ -23,7 +23,7 @@
 # the Free Software Foundation, 51 Franklin Street, Fifth Floor,
 # Boston, MA 02110-1301, USA.
 
-from pygit2 import Oid, Signature
+from pygit2 import Commit, Oid, Repository, Signature
 from pygit2.enums import ObjectType
 
 content = """\
@@ -84,7 +84,7 @@
 # XXX: seems macos wants the space while linux does not
 
 
-def test_commit_signing(gpgsigned):
+def test_commit_signing(gpgsigned: Repository) -> None:
     repo = gpgsigned
     message = 'a simple commit which works'
     author = Signature(
@@ -111,6 +111,7 @@ def test_commit_signing(gpgsigned):
     # create/retrieve signed commit
     oid = repo.create_commit_with_signature(content, gpgsig)
     commit = repo.get(oid)
+    assert isinstance(commit, Commit)
     signature, payload = commit.gpg_signature
 
     # validate signed commit
@@ -133,11 +134,12 @@ def test_commit_signing(gpgsigned):
     assert Oid(hex=parent) == commit.parent_ids[0]
 
 
-def test_get_gpg_signature_when_unsigned(gpgsigned):
+def test_get_gpg_signature_when_unsigned(gpgsigned: Repository) -> None:
     unhash = '5b5b025afb0b4c913b4c338a42934a3863bf3644'
 
     repo = gpgsigned
     commit = repo.get(unhash)
+    assert isinstance(commit, Commit)
     signature, payload = commit.gpg_signature
 
     assert signature is None