Merge pull request #697 from alyssais/commit_sig_key_error

Use Hash#fetch instead of Hash#[] for more understandable error messages

Author: Vicent Martí

ext/rugged/rugged_signature.c

@@ -50,8 +50,8 @@ git_signature *rugged_signature_get(VALUE rb_sig, git_repository *repo)
 
 	Check_Type(rb_sig, T_HASH);
 
-	rb_name = rb_hash_aref(rb_sig, CSTR2SYM("name"));
-	rb_email = rb_hash_aref(rb_sig, CSTR2SYM("email"));
+	rb_name = rb_hash_fetch(rb_sig, CSTR2SYM("name"));
+	rb_email = rb_hash_fetch(rb_sig, CSTR2SYM("email"));
 	rb_time = rb_hash_aref(rb_sig, CSTR2SYM("time"));
 	rb_time_offset = rb_hash_aref(rb_sig, CSTR2SYM("time_offset"));
 

test/commit_test.rb

@@ -452,6 +452,18 @@ def test_write_empty_email_fails
     end
   end
 
+  def test_write_signature_raises_key_error_for_missing_keys
+    person = {:name => 'Jake', :time => Time.now} # no :email
+    assert_raises KeyError do
+      Rugged::Commit.create(@repo,
+      :message => "This is the commit message\n\nThis commit is created from Rugged",
+      :committer => person,
+      :author => person,
+      :parents => [@repo.head.target],
+      :tree => "c4dc1555e4d4fa0e0c9c3fc46734c7c35b3ce90b")
+    end
+  end
+
   def test_create_commit_to_s
     person = {:name => 'Scott', :email => '[email protected]', :time => Time.now }