Change certificate_check to pass true or false for validity.

Also update and clean up some of the test cases.

Author: arthurschreiber

ext/rugged/rugged_remote.c

@@ -104,7 +104,7 @@ static int certificate_check_cb(git_cert *cert, int valid, const char *host, voi
 		return valid ? 0 : GIT_ECERTIFICATE;
 
 	rb_ary_push(args, payload->certificate_check);
-	rb_ary_push(args, INT2FIX(valid));
+	rb_ary_push(args, valid ? Qtrue : Qfalse);
 	rb_ary_push(args, rb_str_new_utf8(host));
 
 	ret = rb_protect(rugged__block_yield_splat, args, &payload->exception);

test/online/fetch_test.rb

@@ -30,45 +30,44 @@ def test_fetch_over_https
     end
 
     def test_fetch_over_https_with_certificate_callback
-      result = {}
       @repo.remotes.create("origin", "https://github.com/libgit2/TestGitRepository.git")
 
+      args = {}
       @repo.fetch("origin", {
         certificate_check: lambda { |valid, host|
-         result[:valid] = valid
-         true
+          args[:valid] = valid
+          args[:host] = host
+
+          true
         }
       })
-      assert_equal result[:valid], 1
+
+      assert_equal({ valid: true, host: "github.com" }, args)
     end
 
     def test_fetch_over_https_with_certificate_callback_fail
-      result = {}
       @repo.remotes.create("origin", "https://github.com/libgit2/TestGitRepository.git")
 
       exception = assert_raises Rugged::NetworkError do
         @repo.fetch("origin", {
-          certificate_check: lambda { |valid, host|
-            result[:valid] = valid
-            false
-          }
+          certificate_check: lambda { |valid, host| false }
         })
       end
+
       assert_equal "user cancelled certificate check", exception.message
     end
 
     def test_fetch_over_https_with_certificate_callback_exception
-      result = {}
       @repo.remotes.create("origin", "https://github.com/libgit2/TestGitRepository.git")
 
       exception = assert_raises RuntimeError do
         @repo.fetch("origin", {
           certificate_check: lambda { |valid, host|
-            result[:valid] = valid
             raise "Exception from callback"
           }
         })
       end
+
       assert_equal "Exception from callback", exception.message
     end
   end