Merge pull request #638 from jasonroelofs/dont-set-valid-flag-on-index

Vicent Martí · web-flow · commit f948cd1d82fd · 2017-10-24T09:00:19.000+02:00
Don't default index entries to "VALID"
diff --git a/ext/rugged/rugged_index.c b/ext/rugged/rugged_index.c
@@ -607,8 +607,6 @@ static void rb_git_indexentry_toC(git_index_entry *entry, VALUE rb_entry)
 		entry->flags &= ~GIT_IDXENTRY_VALID;
 		if (rugged_parse_bool(val))
 			entry->flags |= GIT_IDXENTRY_VALID;
-	} else {
-		entry->flags |= GIT_IDXENTRY_VALID;
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -607,8 +607,6 @@ static void rb_git_indexentry_toC(git_index_entry *entry, VALUE rb_entry)`
`607`	`607`	`entry->flags &= ~GIT_IDXENTRY_VALID;`
`608`	`608`	`if (rugged_parse_bool(val))`
`609`	`609`	`entry->flags \|= GIT_IDXENTRY_VALID;`
`610`		`- } else {`
`611`		`- entry->flags \|= GIT_IDXENTRY_VALID;`
`612`	`610`	`}`
`613`	`611`	`}`
`614`	`612`