IOKit: Fix race condition when trying to delete runloop before it even started

tihmstar · nikias · commit 5506512dae68 · 2025-09-06T20:07:05.000+02:00
diff --git a/src/libirecovery.c b/src/libirecovery.c
@@ -3114,6 +3114,7 @@ irecv_error_t irecv_device_event_unsubscribe(irecv_device_event_context_t contex
 	if (num == 0 && th_event_handler != THREAD_T_NULL && thread_alive(th_event_handler)) {
 #ifdef HAVE_IOKIT
 		if (iokit_runloop) {
+			while (!CFRunLoopIsWaiting(iokit_runloop)) usleep(420);
 			CFRunLoopStop(iokit_runloop);
 			iokit_runloop = NULL;
 		}

Original file line number	Diff line number	Diff line change
`@@ -3114,6 +3114,7 @@ irecv_error_t irecv_device_event_unsubscribe(irecv_device_event_context_t contex`
`3114`	`3114`	`if (num == 0 && th_event_handler != THREAD_T_NULL && thread_alive(th_event_handler)) {`
`3115`	`3115`	`#ifdef HAVE_IOKIT`
`3116`	`3116`	`if (iokit_runloop) {`
	`3117`	`+ while (!CFRunLoopIsWaiting(iokit_runloop)) usleep(420);`
`3117`	`3118`	`CFRunLoopStop(iokit_runloop);`
`3118`	`3119`	`iokit_runloop = NULL;`
`3119`	`3120`	`}`