C++: Use free() instead of delete for C things

Author: nikias

src/Array.cpp

@@ -168,7 +168,7 @@ void Array::Remove(Node* node)
         std::vector<Node*>::iterator it = _array.begin();
         it += pos;
         _array.erase(it);
-        delete node;
+        free(node);
     }
 }
 

src/Data.cpp

@@ -66,14 +66,10 @@ void Data::SetValue(const std::vector<char>& buff)
 
 std::vector<char> Data::GetValue() const
 {
-    char* buff = NULL;
     uint64_t length = 0;
-    plist_get_data_val(_node, &buff, &length);
+    const char* buff = plist_get_data_ptr(_node, &length);
     std::vector<char> ret(buff, buff + length);
-    delete buff;
     return ret;
 }
 
-
-
 }  // namespace PList

src/Dictionary.cpp

@@ -40,7 +40,7 @@ static void dictionary_fill(Dictionary *_this, std::map<std::string,Node*> &map,
         plist_dict_next_item(node, it, &key, &subnode);
         if (key && subnode)
             map[std::string(key)] = Node::FromPlist(subnode, _this);
-        delete key;
+        free(key);
     } while (subnode);
     free(it);
 }
@@ -176,9 +176,9 @@ void Dictionary::Remove(Node* node)
         plist_dict_get_item_key(node->GetPlist(), &key);
         plist_dict_remove_item(_node, key);
         std::string skey = key;
-        delete key;
+        free(key);
         _map.erase(skey);
-        delete node;
+        free(node);
     }
 }
 

src/Key.cpp

@@ -69,7 +69,7 @@ std::string Key::GetValue() const
     char* s = NULL;
     plist_get_key_val(_node, &s);
     std::string ret = s ? s : "";
-    delete s;
+    free(s);
     return ret;
 }
 

src/Structure.cpp

@@ -57,7 +57,7 @@ std::string Structure::ToXml() const
     uint32_t length = 0;
     plist_to_xml(_node, &xml, &length);
     std::string ret(xml, xml+length);
-    delete xml;
+    free(xml);
     return ret;
 }
 
@@ -67,7 +67,7 @@ std::vector<char> Structure::ToBin() const
     uint32_t length = 0;
     plist_to_bin(_node, &bin, &length);
     std::vector<char> ret(bin, bin+length);
-    delete bin;
+    free(bin);
     return ret;
 }