Fix plist_set_date_val to use correct size for data storage

nikias · nikias · commit eee2e519e9ec · 2025-05-12T11:27:35.000+02:00
Otherwise the internal assertion will trigger since the incorrect size will be checked against. Thanks to @michaelwright235, @guyingzhao, and others for pointing this out!
diff --git a/src/plist.c b/src/plist.c
@@ -1548,7 +1548,7 @@ void plist_set_data_val(plist_t node, const char *val, uint64_t length)
 void plist_set_date_val(plist_t node, int32_t sec, int32_t usec)
 {
     double val = (double)sec + (double)usec / 1000000;
-    plist_set_element_val(node, PLIST_DATE, &val, sizeof(struct timeval));
+    plist_set_element_val(node, PLIST_DATE, &val, sizeof(double));
 }
 
 int plist_bool_val_is_true(plist_t boolnode)

Original file line number	Diff line number	Diff line change
`@@ -1548,7 +1548,7 @@ void plist_set_data_val(plist_t node, const char *val, uint64_t length)`
`1548`	`1548`	`void plist_set_date_val(plist_t node, int32_t sec, int32_t usec)`
`1549`	`1549`	`{`
`1550`	`1550`	`double val = (double)sec + (double)usec / 1000000;`
`1551`		`- plist_set_element_val(node, PLIST_DATE, &val, sizeof(struct timeval));`
	`1551`	`+ plist_set_element_val(node, PLIST_DATE, &val, sizeof(double));`
`1552`	`1552`	`}`
`1553`	`1553`
`1554`	`1554`	`int plist_bool_val_is_true(plist_t boolnode)`