Refactor tray icon creation and management API

Removed TrayManager::Create and Destroy methods and their C API equivalents. TrayIcon instances should now be created directly using std::make_shared<TrayIcon>(). Updated examples and documentation to reflect this change, simplifying tray icon lifecycle management.

Author: lijy91

examples/tray_icon_c_example/main.c

@@ -160,7 +160,7 @@ int main() {
   }
 
   // Create tray icon
-  native_tray_icon_t tray_icon = native_tray_manager_create();
+  native_tray_icon_t tray_icon = native_tray_icon_create();
   if (!tray_icon) {
     printf("Error: Failed to create tray icon!\n");
     native_menu_destroy(menu);

examples/tray_icon_example/main.cpp

@@ -27,15 +27,15 @@ int main() {
   [NSApp setActivationPolicy:NSApplicationActivationPolicyAccessory];
 #endif
 
-  // Get TrayManager instance (singleton pattern)
+  // Check if tray icons are supported
   TrayManager& trayManager = TrayManager::GetInstance();
   if (!trayManager.IsSupported()) {
     std::cerr << "Tray icons are not supported on this platform!" << std::endl;
     return 1;
   }
 
-  // Create a tray icon
-  auto trayIcon = trayManager.Create();
+  // Create a tray icon directly
+  auto trayIcon = std::make_shared<TrayIcon>();
   if (!trayIcon) {
     std::cerr << "Failed to create tray icon!" << std::endl;
     return 1;

examples/window_c_example/main.c

@@ -290,7 +290,7 @@ int main() {
     native_window_options_destroy(options);
 
     // Create tray icon
-    g_tray_icon = native_tray_manager_create();
+    g_tray_icon = native_tray_icon_create();
     if (g_tray_icon != NULL) {
         native_tray_icon_set_icon(g_tray_icon,
             "data:image/png;base64,"

examples/window_example/main.cpp

@@ -42,7 +42,7 @@ int main() {
   options.centered = true;
   std::shared_ptr<Window> window_ptr = window_manager.Create(options);
 
-  std::shared_ptr<TrayIcon> tray_icon_ptr = tray_manager.Create();
+  std::shared_ptr<TrayIcon> tray_icon_ptr = std::make_shared<TrayIcon>();
   if (tray_icon_ptr != nullptr) {
     TrayIcon& tray_icon = *tray_icon_ptr;
     tray_icon.SetIcon(

src/capi/tray_manager_c.cpp

@@ -14,16 +14,6 @@ bool native_tray_manager_is_supported(void) {
   }
 }
 
-native_tray_icon_t native_tray_manager_create(void) {
-  try {
-    auto tray_icon = TrayManager::GetInstance().Create();
-    return tray_icon ? static_cast<native_tray_icon_t>(tray_icon.get())
-                     : nullptr;
-  } catch (...) {
-    return nullptr;
-  }
-}
-
 native_tray_icon_t native_tray_manager_get(native_tray_icon_id_t tray_icon_id) {
   try {
     auto tray_icon = TrayManager::GetInstance().Get(tray_icon_id);
@@ -67,14 +57,6 @@ native_tray_icon_list_t native_tray_manager_get_all(void) {
   }
 }
 
-bool native_tray_manager_destroy(native_tray_icon_id_t tray_icon_id) {
-  try {
-    return TrayManager::GetInstance().Destroy(tray_icon_id);
-  } catch (...) {
-    return false;
-  }
-}
-
 // Utility functions
 
 void native_tray_icon_list_free(native_tray_icon_list_t list) {

src/capi/tray_manager_c.h

@@ -35,13 +35,6 @@ typedef struct {
 FFI_PLUGIN_EXPORT
 bool native_tray_manager_is_supported(void);
 
-/**
- * Create a new tray icon
- * @return Tray icon handle, or NULL if creation failed
- */
-FFI_PLUGIN_EXPORT
-native_tray_icon_t native_tray_manager_create(void);
-
 /**
  * Get a tray icon by its ID
  * @param tray_icon_id The tray icon ID
@@ -57,14 +50,6 @@ native_tray_icon_t native_tray_manager_get(native_tray_icon_id_t tray_icon_id);
 FFI_PLUGIN_EXPORT
 native_tray_icon_list_t native_tray_manager_get_all(void);
 
-/**
- * Destroy a tray icon by its ID
- * @param tray_icon_id The tray icon ID to destroy
- * @return true if tray icon was found and destroyed, false otherwise
- */
-FFI_PLUGIN_EXPORT
-bool native_tray_manager_destroy(native_tray_icon_id_t tray_icon_id);
-
 /**
  * Utility functions
  */

src/platform/linux/tray_manager_linux.cpp

@@ -62,22 +62,6 @@ bool TrayManager::IsSupported() {
 #endif
 }
 
-std::shared_ptr<TrayIcon> TrayManager::Create() {
-  std::lock_guard<std::mutex> lock(mutex_);
-
-#if HAS_GTK && HAS_AYATANA_APPINDICATOR
-  // Create tray icon with platform-specific initialization handled internally
-  auto tray = std::make_shared<TrayIcon>();
-  tray->id = next_tray_id_++;
-  trays_[tray->id] = tray;
-
-  return tray;
-#else
-  // AppIndicator not available, return nullptr
-  return nullptr;
-#endif
-}
-
 std::shared_ptr<TrayIcon> TrayManager::Get(TrayIconID id) {
   std::lock_guard<std::mutex> lock(mutex_);
 
@@ -98,18 +82,4 @@ std::vector<std::shared_ptr<TrayIcon>> TrayManager::GetAll() {
   return trays;
 }
 
-bool TrayManager::Destroy(TrayIconID id) {
-  std::lock_guard<std::mutex> lock(mutex_);
-
-  auto it = trays_.find(id);
-  if (it != trays_.end()) {
-    // Remove the tray icon from our container
-    // The shared_ptr will automatically clean up when the last reference is
-    // released
-    trays_.erase(it);
-    return true;
-  }
-  return false;
-}
-
 }  // namespace nativeapi

src/platform/macos/tray_manager_macos.mm

@@ -56,17 +56,6 @@
   return true;
 }
 
-std::shared_ptr<TrayIcon> TrayManager::Create() {
-  std::lock_guard<std::mutex> lock(mutex_);
-
-  // Create tray icon with platform-specific initialization handled internally
-  auto tray = std::make_shared<TrayIcon>();
-  tray->id = next_tray_id_++;
-  trays_[tray->id] = tray;
-
-  return tray;
-}
-
 std::shared_ptr<TrayIcon> TrayManager::Get(TrayIconID id) {
   std::lock_guard<std::mutex> lock(mutex_);
 
@@ -87,17 +76,4 @@
   return trays;
 }
 
-bool TrayManager::Destroy(TrayIconID id) {
-  std::lock_guard<std::mutex> lock(mutex_);
-
-  auto it = trays_.find(id);
-  if (it != trays_.end()) {
-    // Remove the tray icon from our container
-    // The shared_ptr will automatically clean up when the last reference is released
-    trays_.erase(it);
-    return true;
-  }
-  return false;
-}
-
 }  // namespace nativeapi

src/platform/windows/tray_manager_windows.cpp

@@ -87,17 +87,6 @@ bool TrayManager::IsSupported() {
   return true;  // Windows always supports system tray
 }
 
-std::shared_ptr<TrayIcon> TrayManager::Create() {
-  std::lock_guard<std::mutex> lock(mutex_);
-
-  // Create tray icon with platform-specific initialization handled internally
-  auto tray = std::make_shared<TrayIcon>();
-  tray->id = next_tray_id_++;
-  trays_[tray->id] = tray;
-
-  return tray;
-}
-
 std::shared_ptr<TrayIcon> TrayManager::Get(TrayIconID id) {
   std::lock_guard<std::mutex> lock(mutex_);
 
@@ -118,18 +107,4 @@ std::vector<std::shared_ptr<TrayIcon>> TrayManager::GetAll() {
   return trays;
 }
 
-bool TrayManager::Destroy(TrayIconID id) {
-  std::lock_guard<std::mutex> lock(mutex_);
-
-  auto it = trays_.find(id);
-  if (it != trays_.end()) {
-    // Remove the tray icon from our container
-    // The shared_ptr will automatically clean up when the last reference is
-    // released
-    trays_.erase(it);
-    return true;
-  }
-  return false;
-}
-
 }  // namespace nativeapi

src/tray_icon.h

@@ -58,7 +58,7 @@ typedef long TrayIconID;
  * trayIcon->SetContextMenu(menu);
  *
  * // Show the tray icon
- * trayIcon->Show();
+ * trayIcon->SetVisible(true);
  * ```
  */
 class TrayIcon : public EventEmitter, public NativeObjectProvider {