Refactor menu positioning to use PositioningStrategy

Replaces coordinate-based menu opening with a unified PositioningStrategy API across C, C++, and platform implementations. Adds C API bindings for positioning strategies, updates all usages to pass a strategy object, and removes legacy coordinate-based methods. This enables more flexible menu placement, including absolute, cursor, and relative positioning.

Author: lijy91

examples/menu_c_example/main.c

@@ -3,6 +3,7 @@
 #include <string.h>
 #include "../../src/capi/application_c.h"
 #include "../../src/capi/menu_c.h"
+#include "../../src/capi/positioning_strategy_c.h"
 
 // Event callback functions
 void on_menu_item_clicked(const void* event, void* user_data) {
@@ -154,8 +155,9 @@ int main() {
   // Note: Programmatic event triggering is no longer available via trigger API.
   // Events can only be triggered through actual user interaction.
   printf("\n=== Programmatic Event Triggering Removed ===\n");
-  printf("Note: The trigger API has been removed. Events are now only "
-         "triggered through user interaction.\n");
+  printf(
+      "Note: The trigger API has been removed. Events are now only "
+      "triggered through user interaction.\n");
 
   // Demonstrate listener removal
   printf("\n=== Testing Listener Removal ===\n");
@@ -167,18 +169,22 @@ int main() {
     printf("Failed to remove checkbox click listener\n");
   }
 
-  printf("Checkbox item listener removed. Events will now only be triggered "
-         "through user interaction.\n");
+  printf(
+      "Checkbox item listener removed. Events will now only be triggered "
+      "through user interaction.\n");
 
   // Open menu as context menu (this may not work in console applications)
   printf("\n=== Attempting to Open Context Menu ===\n");
   printf("Note: Context menu display may not work in console applications\n");
 
-  if (native_menu_open_at(menu, 100, 100)) {
+  native_point_t point = {100, 100};
+  native_positioning_strategy_t strategy = native_positioning_strategy_absolute(&point);
+  if (native_menu_open(menu, strategy)) {
     printf("Context menu opened successfully\n");
   } else {
     printf("Failed to open context menu (expected in console app)\n");
   }
+  native_positioning_strategy_free(strategy);
 
   // Test additional functionality
   printf("\n=== Testing Additional Functionality ===\n");

examples/menu_example/main.cpp

@@ -106,7 +106,7 @@ int main() {
     std::cout << "Note: Context menu display may not work in console applications" << std::endl;
 
     // Try to show at screen coordinates (100, 100)
-    if (menu->Open(100, 100)) {
+    if (menu->Open(PositioningStrategy::Absolute({100, 100}))) {
       std::cout << "Context menu opened successfully" << std::endl;
     } else {
       std::cout << "Failed to open context menu (expected in console app)" << std::endl;

src/capi/menu_c.cpp

@@ -5,6 +5,7 @@
 #include <map>
 #include <memory>
 #include <optional>
+#include "../foundation/positioning_strategy.h"
 #include "../global_registry.h"
 #include "../image.h"
 #include "../menu.h"
@@ -837,25 +838,14 @@ native_menu_item_list_t native_menu_get_all_items(native_menu_t menu) {
   }
 }
 
-bool native_menu_open_at(native_menu_t menu, double x, double y) {
-  if (!menu)
-    return false;
-
-  try {
-    auto menu_ptr = static_cast<Menu*>(menu);
-    return menu_ptr->Open(x, y);
-  } catch (...) {
-    return false;
-  }
-}
-
-bool native_menu_open(native_menu_t menu) {
-  if (!menu)
+bool native_menu_open(native_menu_t menu, native_positioning_strategy_t strategy) {
+  if (!menu || !strategy)
     return false;
 
   try {
     auto menu_ptr = static_cast<Menu*>(menu);
-    return menu_ptr->Open();
+    auto strategy_ptr = static_cast<PositioningStrategy*>(strategy);
+    return menu_ptr->Open(*strategy_ptr);
   } catch (...) {
     return false;
   }
@@ -873,7 +863,6 @@ bool native_menu_close(native_menu_t menu) {
   }
 }
 
-
 // New menu event listener API implementation
 int native_menu_add_listener(native_menu_t menu,
                              native_menu_event_type_t event_type,

src/capi/menu_c.h

@@ -16,6 +16,7 @@ extern "C" {
 
 #include "geometry_c.h"
 #include "image_c.h"
+#include "positioning_strategy_c.h"
 
 /**
  * Opaque handles for menu objects
@@ -473,22 +474,13 @@ FFI_PLUGIN_EXPORT
 native_menu_item_list_t native_menu_get_all_items(native_menu_t menu);
 
 /**
- * Open the menu as a context menu at specified coordinates
+ * Open the menu as a context menu using the specified positioning strategy
  * @param menu The menu
- * @param x The x-coordinate in screen coordinates
- * @param y The y-coordinate in screen coordinates
+ * @param strategy The positioning strategy determining where to display the menu
  * @return true if menu was opened successfully, false otherwise
  */
 FFI_PLUGIN_EXPORT
-bool native_menu_open_at(native_menu_t menu, double x, double y);
-
-/**
- * Open the menu as a context menu at default location
- * @param menu The menu
- * @return true if menu was opened successfully, false otherwise
- */
-FFI_PLUGIN_EXPORT
-bool native_menu_open(native_menu_t menu);
+bool native_menu_open(native_menu_t menu, native_positioning_strategy_t strategy);
 
 /**
  * Close the menu if it's currently showing

src/capi/positioning_strategy_c.cpp

@@ -0,0 +1,46 @@
+#include "positioning_strategy_c.h"
+#include "../foundation/positioning_strategy.h"
+
+using namespace nativeapi;
+
+extern "C" {
+
+native_positioning_strategy_t native_positioning_strategy_absolute(const native_point_t* point) {
+  if (!point) {
+    return nullptr;
+  }
+
+  Point cpp_point{point->x, point->y};
+  PositioningStrategy* strategy = new PositioningStrategy(PositioningStrategy::Absolute(cpp_point));
+  return static_cast<native_positioning_strategy_t>(strategy);
+}
+
+native_positioning_strategy_t native_positioning_strategy_cursor_position() {
+  PositioningStrategy* strategy = new PositioningStrategy(PositioningStrategy::CursorPosition());
+  return static_cast<native_positioning_strategy_t>(strategy);
+}
+
+native_positioning_strategy_t native_positioning_strategy_relative(const native_rectangle_t* rect,
+                                                                   const native_point_t* offset) {
+  if (!rect) {
+    return nullptr;
+  }
+
+  Rectangle cpp_rect{rect->x, rect->y, rect->width, rect->height};
+  Point cpp_offset{0, 0};
+  if (offset) {
+    cpp_offset = Point{offset->x, offset->y};
+  }
+
+  PositioningStrategy* strategy =
+      new PositioningStrategy(PositioningStrategy::Relative(cpp_rect, cpp_offset));
+  return static_cast<native_positioning_strategy_t>(strategy);
+}
+
+void native_positioning_strategy_free(native_positioning_strategy_t strategy) {
+  if (strategy) {
+    delete static_cast<PositioningStrategy*>(strategy);
+  }
+}
+
+}  // extern "C"

src/capi/positioning_strategy_c.h

@@ -0,0 +1,73 @@
+#pragma once
+
+#include <stdbool.h>
+
+#include "geometry_c.h"
+
+#if _WIN32
+#define FFI_PLUGIN_EXPORT __declspec(dllexport)
+#else
+#define FFI_PLUGIN_EXPORT
+#endif
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+/**
+ * Type of positioning strategy
+ */
+typedef enum {
+  NATIVE_POSITIONING_ABSOLUTE,
+  NATIVE_POSITIONING_CURSOR_POSITION,
+  NATIVE_POSITIONING_RELATIVE
+} native_positioning_strategy_type_t;
+
+/**
+ * Opaque handle for positioning strategy
+ */
+typedef void* native_positioning_strategy_t;
+
+/**
+ * Create a positioning strategy for absolute positioning at fixed coordinates
+ * @param point Point in screen coordinates
+ * @return Positioning strategy handle
+ */
+FFI_PLUGIN_EXPORT
+native_positioning_strategy_t native_positioning_strategy_absolute(const native_point_t* point);
+
+/**
+ * Create a positioning strategy for positioning at current mouse location
+ * @return Positioning strategy handle
+ */
+FFI_PLUGIN_EXPORT
+native_positioning_strategy_t native_positioning_strategy_cursor_position();
+
+/**
+ * Create a positioning strategy for positioning relative to a rectangle
+ * @param rect Rectangle in screen coordinates to position relative to
+ * @param offset Offset point to apply to the position, or NULL for no offset
+ * @return Positioning strategy handle
+ *
+ * @example
+ * ```c
+ * native_rectangle_t buttonRect = {100, 100, 50, 30};
+ * native_point_t offset = {0, 10};
+ * native_positioning_strategy_t strategy = native_positioning_strategy_relative(&buttonRect,
+ * &offset); native_menu_open(menu, strategy); native_positioning_strategy_free(strategy);
+ * ```
+ */
+FFI_PLUGIN_EXPORT
+native_positioning_strategy_t native_positioning_strategy_relative(const native_rectangle_t* rect,
+                                                                   const native_point_t* offset);
+
+/**
+ * Free a positioning strategy handle
+ * @param strategy The positioning strategy to free
+ */
+FFI_PLUGIN_EXPORT
+void native_positioning_strategy_free(native_positioning_strategy_t strategy);
+
+#ifdef __cplusplus
+}
+#endif

src/capi/tray_icon_c.cpp

@@ -376,18 +376,6 @@ bool native_tray_icon_remove_listener(native_tray_icon_t tray_icon, int listener
   }
 }
 
-bool native_tray_icon_open_context_menu_at(native_tray_icon_t tray_icon, double x, double y) {
-  if (!tray_icon)
-    return false;
-
-  try {
-    auto tray_icon_ptr = static_cast<TrayIcon*>(tray_icon);
-    return tray_icon_ptr->OpenContextMenu(x, y);
-  } catch (...) {
-    return false;
-  }
-}
-
 bool native_tray_icon_open_context_menu(native_tray_icon_t tray_icon) {
   if (!tray_icon)
     return false;

src/capi/tray_icon_c.h

@@ -213,16 +213,6 @@ int native_tray_icon_add_listener(native_tray_icon_t tray_icon,
 FFI_PLUGIN_EXPORT
 bool native_tray_icon_remove_listener(native_tray_icon_t tray_icon, int listener_id);
 
-/**
- * Open the context menu at specified coordinates
- * @param tray_icon The tray icon
- * @param x The x-coordinate in screen coordinates
- * @param y The y-coordinate in screen coordinates
- * @return true if menu was opened successfully, false otherwise
- */
-FFI_PLUGIN_EXPORT
-bool native_tray_icon_open_context_menu_at(native_tray_icon_t tray_icon, double x, double y);
-
 /**
  * Open the context menu at default location
  * @param tray_icon The tray icon

src/foundation/geometry.h

@@ -53,7 +53,7 @@ struct Rectangle {
  * @example
  * ```cpp
  * // Position menu below the button, aligned to the left
- * menu->Open(PositioningStrategy::Absolute(100, 100), Placement::BottomStart);
+ * menu->Open(PositioningStrategy::Absolute({100, 100}), Placement::BottomStart);
  *
  * // Position popover to the right, aligned to the top
  * popover->Open(PositioningStrategy::CursorPosition(), Placement::RightStart);

src/foundation/positioning_strategy.cpp

@@ -5,9 +5,9 @@ namespace nativeapi {
 PositioningStrategy::PositioningStrategy(Type type)
     : type_(type), absolute_position_{0, 0}, relative_rect_{0, 0, 0, 0}, relative_offset_{0, 0} {}
 
-PositioningStrategy PositioningStrategy::Absolute(double x, double y) {
+PositioningStrategy PositioningStrategy::Absolute(const Point& point) {
   PositioningStrategy strategy(Type::Absolute);
-  strategy.absolute_position_ = {x, y};
+  strategy.absolute_position_ = point;
   return strategy;
 }
 
@@ -23,4 +23,3 @@ PositioningStrategy PositioningStrategy::Relative(const Rectangle& rect, const P
 }
 
 }  // namespace nativeapi
-