Refactor type casting and memory management on macOS

Updated type casting for tray icon IDs to use explicit static_cast for better type safety. Removed unnecessary manual memory management (release calls) for Objective-C objects in image handling, relying on ARC. Cleaned up unused variable in menu item state logic.

Author: lijy91

src/capi/tray_manager_c.cpp

@@ -16,7 +16,7 @@ bool native_tray_manager_is_supported(void) {
 
 native_tray_icon_t native_tray_manager_get(native_tray_icon_id_t tray_icon_id) {
   try {
-    auto tray_icon = TrayManager::GetInstance().Get(tray_icon_id);
+    auto tray_icon = TrayManager::GetInstance().Get(static_cast<TrayIconId>(tray_icon_id));
     return tray_icon ? static_cast<native_tray_icon_t>(tray_icon.get())
                      : nullptr;
   } catch (...) {

src/platform/macos/image_macos.mm

@@ -20,9 +20,6 @@
   Impl() : ns_image_(nil), size_({0, 0}), format_("Unknown") {}
 
   ~Impl() {
-    if (ns_image_) {
-      [ns_image_ release];
-    }
   }
 
   Impl(const Impl& other)
@@ -34,9 +31,6 @@
 
   Impl& operator=(const Impl& other) {
     if (this != &other) {
-      if (ns_image_) {
-        [ns_image_ release];
-      }
       ns_image_ = nil;
       source_ = other.source_;
       size_ = other.size_;
@@ -124,10 +118,7 @@
 
       // Default assumption for base64 images
       image->pimpl_->format_ = "PNG";
-
-      [imageData release];
     } else {
-      [imageData release];
       return nullptr;
     }
   } else {
@@ -179,7 +170,6 @@
   }
 
   NSData* pngData = [bitmapRep representationUsingType:NSBitmapImageFileTypePNG properties:@{}];
-  [bitmapRep release];
 
   if (!pngData) {
     return "";
@@ -226,7 +216,6 @@
   }
 
   NSData* imageData = [bitmapRep representationUsingType:fileType properties:properties];
-  [bitmapRep release];
 
   if (!imageData) {
     return false;

src/platform/macos/menu_macos.mm

@@ -444,7 +444,6 @@ - (void)menuDidClose:(NSMenu*)menu {
             // Get the MenuItemId from the associated object
             NSNumber* sibling_id_obj = objc_getAssociatedObject(sibling, kMenuItemIdKey);
             if (sibling_id_obj) {
-              MenuItemId sibling_id = [sibling_id_obj longValue];
               // Find the corresponding MenuItem in the parent menu's items
               // This is a simplified approach - in practice, you might need to store
               // a reference to the parent menu or use a different strategy

src/platform/macos/tray_icon_macos.mm

@@ -44,7 +44,7 @@ - (void)statusItemClicked:(id)sender;
       NSNumber* allocated_id = objc_getAssociatedObject(status_item, kTrayIconIdKey);
       if (allocated_id) {
         // Reuse allocated ID
-        id_ = [allocated_id longValue];
+        id_ = static_cast<TrayIconId>([allocated_id longValue]);
       } else {
         // Allocate new ID and store it
         id_ = IdAllocator::Allocate<TrayIcon>();