Remove system icon support from Image API

Eliminated the ability to create images from platform-specific system icons across all platforms. Removed related methods, documentation, and C API functions. This simplifies the image API and reduces platform-specific code.

Author: lijy91

examples/tray_icon_example/main.cpp

@@ -46,10 +46,6 @@ int main() {
   trayIcon->SetTitle("Test App");
   trayIcon->SetTooltip("This is a test tray icon");
 
-  // Try to set a system icon (using a system-provided icon)
-  auto icon = nativeapi::Image::FromSystemIcon("NSImageNameStatusAvailable");
-  trayIcon->SetIcon(icon);
-
   // Set up event listeners
   trayIcon->AddListener<TrayIconClickedEvent>(
       [](const TrayIconClickedEvent& event) {
@@ -180,4 +176,4 @@ int main() {
   // Cleanup
   delete should_exit;
   return 0;
-}
+}

src/capi/image_c.cpp

@@ -48,27 +48,6 @@ native_image_t native_image_from_base64(const char* base64_data) {
   return nullptr;
 }
 
-// Create an image from a platform-specific system icon
-native_image_t native_image_from_system_icon(const char* icon_name) {
-  if (!icon_name) {
-    return nullptr;
-  }
-
-  try {
-    auto image = Image::FromSystemIcon(icon_name);
-    if (image) {
-      auto size = image->GetSize();
-      if (size.width > 0 && size.height > 0) {
-        return new std::shared_ptr<Image>(image);
-      }
-    }
-  } catch (...) {
-    // Handle exceptions
-  }
-
-  return nullptr;
-}
-
 // Destroy an image and release its resources
 void native_image_destroy(native_image_t image) {
   if (image) {

src/capi/image_c.h

@@ -41,14 +41,6 @@ native_image_t native_image_from_file(const char* file_path);
 FFI_PLUGIN_EXPORT
 native_image_t native_image_from_base64(const char* base64_data);
 
-/**
- * Create an image from a platform-specific system icon
- * @param icon_name Platform-specific system icon name/identifier
- * @return Image handle, or NULL if icon not found
- */
-FFI_PLUGIN_EXPORT
-native_image_t native_image_from_system_icon(const char* icon_name);
-
 /**
  * Destroy an image and release its resources
  * @param image The image to destroy

src/image.h

@@ -22,15 +22,14 @@ namespace nativeapi {
  * Features:
  * - Load images from file paths
  * - Load images from base64-encoded strings
- * - Platform-specific system icon support
  * - Automatic format detection and conversion
  * - Memory-efficient internal representation
  *
  * @note This class uses the PIMPL idiom to hide platform-specific
  * implementation details and ensure binary compatibility.
  *
  * @note All Image instances must be created using static factory methods
- * (FromFile, FromBase64, FromSystemIcon). Empty/null images are represented
+ * (FromFile, FromBase64). Empty/null images are represented
  * using std::shared_ptr<Image>{nullptr}.
  *
  * @note Assignment operations are not supported to avoid resource management
@@ -146,31 +145,6 @@ class Image : public NativeObjectProvider {
    */
   static std::shared_ptr<Image> FromBase64(const std::string& base64_data);
 
-  /**
-   * @brief Create an image from a platform-specific system icon.
-   *
-   * Creates an image using a system-provided icon identifier. The available
-   * icons and their identifiers are platform-specific.
-   *
-   * @param icon_name Platform-specific system icon name/identifier
-   * @return A shared pointer to the created Image, or nullptr if icon not found
-   *
-   * @note System icon names vary by platform:
-   *       - macOS: NSImage names (e.g., "NSApplicationIcon", "NSFolder")
-   *       - Windows: System icon IDs (e.g., "IDI_APPLICATION", "IDI_WARNING")
-   *       - Linux: FreeDesktop icon names (e.g., "application-exit", "folder")
-   *
-   * @example
-   * ```cpp
-   * // macOS
-   * auto image = Image::FromSystemIcon("NSApplicationIcon");
-   *
-   * // Cross-platform generic names (if supported)
-   * auto warningIcon = Image::FromSystemIcon("warning");
-   * ```
-   */
-  static std::shared_ptr<Image> FromSystemIcon(const std::string& icon_name);
-
   /**
    * @brief Get the size of the image in pixels.
    *

src/platform/linux/image_linux.cpp

@@ -178,49 +178,6 @@ std::shared_ptr<Image> Image::FromBase64(const std::string& base64_data) {
   return image;
 }
 
-std::shared_ptr<Image> Image::FromSystemIcon(const std::string& icon_name) {
-  auto image = std::shared_ptr<Image>(new Image());
-
-  // Try to load icon from the current icon theme
-  GtkIconTheme* icon_theme = gtk_icon_theme_get_default();
-  if (!icon_theme) {
-    return nullptr;
-  }
-
-  // Try to load icon at default size (48x48)
-  GtkIconInfo* icon_info = gtk_icon_theme_lookup_icon(
-      icon_theme, icon_name.c_str(), 48, GTK_ICON_LOOKUP_FORCE_SIZE);
-
-  if (icon_info) {
-    GError* error = nullptr;
-    GdkPixbuf* pixbuf = gtk_icon_info_load_icon(icon_info, &error);
-
-    if (pixbuf) {
-      image->pimpl_->pixbuf_ = pixbuf;
-      image->pimpl_->source_ = icon_name;
-
-      // Get actual image size
-      int width = gdk_pixbuf_get_width(pixbuf);
-      int height = gdk_pixbuf_get_height(pixbuf);
-      image->pimpl_->size_ = {static_cast<double>(width),
-                              static_cast<double>(height)};
-      image->pimpl_->format_ = "System";
-    } else {
-      if (error) {
-        g_error_free(error);
-      }
-      g_object_unref(icon_info);
-      return nullptr;
-    }
-
-    g_object_unref(icon_info);
-  } else {
-    return nullptr;
-  }
-
-  return image;
-}
-
 Size Image::GetSize() const {
   return pimpl_->size_;
 }

src/platform/macos/image_macos.mm

@@ -127,27 +127,6 @@
   return image;
 }
 
-std::shared_ptr<Image> Image::FromSystemIcon(const std::string& icon_name) {
-  auto image = std::shared_ptr<Image>(new Image());
-
-  NSString* nsIconName = [NSString stringWithUTF8String:icon_name.c_str()];
-  NSImage* nsImage = [NSImage imageWithSystemSymbolName:nsIconName accessibilityDescription:nil];
-
-  if (nsImage) {
-    image->pimpl_->ns_image_ = [nsImage copy];
-    image->pimpl_->source_ = icon_name;
-
-    // Get actual image size
-    NSSize nsSize = [nsImage size];
-    image->pimpl_->size_ = {static_cast<double>(nsSize.width), static_cast<double>(nsSize.height)};
-    image->pimpl_->format_ = "System";
-  } else {
-    return nullptr;
-  }
-
-  return image;
-}
-
 Size Image::GetSize() const {
   return pimpl_->size_;
 }

src/platform/windows/image_windows.cpp

@@ -260,55 +260,6 @@ std::shared_ptr<Image> Image::FromBase64(const std::string& base64_data) {
   return image;
 }
 
-std::shared_ptr<Image> Image::FromSystemIcon(const std::string& icon_name) {
-  EnsureGdiplusInitialized();
-  auto image = std::shared_ptr<Image>(new Image());
-
-  HICON hIcon = nullptr;
-
-  // Try to load predefined system icons
-  if (icon_name == "IDI_APPLICATION" || icon_name == "application") {
-    hIcon = LoadIcon(NULL, IDI_APPLICATION);
-  } else if (icon_name == "IDI_ERROR" || icon_name == "error") {
-    hIcon = LoadIcon(NULL, IDI_ERROR);
-  } else if (icon_name == "IDI_QUESTION" || icon_name == "question") {
-    hIcon = LoadIcon(NULL, IDI_QUESTION);
-  } else if (icon_name == "IDI_WARNING" || icon_name == "warning") {
-    hIcon = LoadIcon(NULL, IDI_WARNING);
-  } else if (icon_name == "IDI_INFORMATION" || icon_name == "information") {
-    hIcon = LoadIcon(NULL, IDI_INFORMATION);
-  } else if (icon_name == "IDI_WINLOGO" || icon_name == "winlogo") {
-    hIcon = LoadIcon(NULL, IDI_WINLOGO);
-  } else if (icon_name == "IDI_SHIELD" || icon_name == "shield") {
-    hIcon = LoadIcon(NULL, IDI_SHIELD);
-  }
-
-  if (hIcon) {
-    Gdiplus::Bitmap* bitmap = Gdiplus::Bitmap::FromHICON(hIcon);
-
-    if (bitmap && bitmap->GetLastStatus() == Gdiplus::Ok) {
-      image->pimpl_->bitmap_ = bitmap;
-      image->pimpl_->source_ = icon_name;
-
-      // Get actual image size
-      UINT width = bitmap->GetWidth();
-      UINT height = bitmap->GetHeight();
-      image->pimpl_->size_ = {static_cast<double>(width),
-                              static_cast<double>(height)};
-      image->pimpl_->format_ = "System";
-    } else {
-      if (bitmap) {
-        delete bitmap;
-      }
-      return nullptr;
-    }
-  } else {
-    return nullptr;
-  }
-
-  return image;
-}
-
 Size Image::GetSize() const {
   return pimpl_->size_;
 }

src/platform/windows/menu_windows.cpp

@@ -1,8 +1,8 @@
 #include <windows.h>
+#include <iostream>
 #include <memory>
 #include <optional>
 #include <vector>
-#include <iostream>
 #include "../../foundation/id_allocator.h"
 #include "../../image.h"
 #include "../../menu.h"
@@ -93,7 +93,6 @@ HWND GetMainWindowForCurrentThread() {
   // First try to get the foreground window
   HWND hwnd = nullptr;
 
-
   // Use EnumWindows to find the main window
   struct EnumData {
     HWND main_window;

src/platform/windows/tray_icon_windows.cpp

@@ -33,14 +33,12 @@ class TrayIcon::Impl {
   using RightClickedCallback = std::function<void(TrayIconId)>;
   using DoubleClickedCallback = std::function<void(TrayIconId)>;
 
-  Impl()
-      : hwnd_(nullptr),
-        icon_handle_(nullptr),
-        owns_window_(false) {
+  Impl() : hwnd_(nullptr), icon_handle_(nullptr), owns_window_(false) {
     tray_icon_id_ = IdAllocator::Allocate<TrayIcon>();
   }
 
-  Impl(HWND hwnd, bool owns_window,
+  Impl(HWND hwnd,
+       bool owns_window,
        ClickedCallback clicked_callback,
        RightClickedCallback right_clicked_callback,
        DoubleClickedCallback double_clicked_callback)
@@ -85,17 +83,18 @@ class TrayIcon::Impl {
                                           UINT message,
                                           WPARAM wparam,
                                           LPARAM lparam) {
-    if (message == WM_USER + 1 && wparam == static_cast<WPARAM>(tray_icon_id_)) {
+    if (message == WM_USER + 1 &&
+        wparam == static_cast<WPARAM>(tray_icon_id_)) {
       if (lparam == WM_LBUTTONUP) {
-        std::cout << "TrayIcon: Left button clicked, tray_icon_id = " << tray_icon_id_
-                  << std::endl;
+        std::cout << "TrayIcon: Left button clicked, tray_icon_id = "
+                  << tray_icon_id_ << std::endl;
         // Call clicked callback
         if (clicked_callback_) {
           clicked_callback_(tray_icon_id_);
         }
       } else if (lparam == WM_RBUTTONUP) {
-        std::cout << "TrayIcon: Right button clicked, tray_icon_id = " << tray_icon_id_
-                  << std::endl;
+        std::cout << "TrayIcon: Right button clicked, tray_icon_id = "
+                  << tray_icon_id_ << std::endl;
         // Call right clicked callback
         if (right_clicked_callback_) {
           right_clicked_callback_(tray_icon_id_);
@@ -173,7 +172,8 @@ TrayIcon::TrayIcon(void* native_tray_icon) {
   } else {
     // Wrap existing native tray icon
     // In a real implementation, you'd extract HWND from the tray parameter
-    // For now, this is mainly used by TrayManager for creating uninitialized icons
+    // For now, this is mainly used by TrayManager for creating uninitialized
+    // icons
   }
 
   // Initialize the Impl with the window handle
@@ -192,10 +192,9 @@ TrayIcon::TrayIcon(void* native_tray_icon) {
       this->Emit<TrayIconDoubleClickedEvent>(id);
     };
 
-    pimpl_ = std::make_unique<Impl>(hwnd, owns_window,
-                                   std::move(clicked_callback),
-                                   std::move(right_clicked_callback),
-                                   std::move(double_clicked_callback));
+    pimpl_ = std::make_unique<Impl>(
+        hwnd, owns_window, std::move(clicked_callback),
+        std::move(right_clicked_callback), std::move(double_clicked_callback));
   } else {
     // Failed to create window, create uninitialized Impl
     pimpl_ = std::make_unique<Impl>();

src/tray_icon_event.h

@@ -28,8 +28,7 @@ class TrayIconEvent : public Event {
  */
 class TrayIconClickedEvent : public TrayIconEvent {
  public:
-  TrayIconClickedEvent(TrayIconId tray_icon_id)
-      : tray_icon_id_(tray_icon_id) {}
+  TrayIconClickedEvent(TrayIconId tray_icon_id) : tray_icon_id_(tray_icon_id) {}
 
   TrayIconId GetTrayIconId() const { return tray_icon_id_; }