Remove item text from MenuItemClickedEvent

Refactored MenuItemClickedEvent to no longer require or emit the menu item's text. Updated Linux, macOS, and Windows platform code to match the new event signature, simplifying event handling and reducing unnecessary data passing.

Author: lijy91

src/menu_event.h

@@ -65,17 +65,14 @@ class MenuClosedEvent : public MenuEvent {
  */
 class MenuItemClickedEvent : public MenuEvent {
  public:
-  MenuItemClickedEvent(MenuItemId item_id, const std::string& item_text)
-      : item_id_(item_id), item_text_(item_text) {}
+  MenuItemClickedEvent(MenuItemId item_id) : item_id_(item_id) {}
 
   MenuItemId GetItemId() const { return item_id_; }
-  const std::string& GetItemText() const { return item_text_; }
 
   std::string GetTypeName() const override { return "MenuItemClickedEvent"; }
 
  private:
   MenuItemId item_id_;
-  std::string item_text_;
 };
 
 /**

src/platform/linux/menu_linux.cpp

@@ -19,11 +19,7 @@ static void OnGtkMenuItemActivate(GtkMenuItem* /*item*/, gpointer user_data) {
   if (!menu_item) {
     return;
   }
-  std::string text = "";
-  if (auto label = menu_item->GetLabel(); label.has_value()) {
-    text = *label;
-  }
-  menu_item->Emit(MenuItemClickedEvent(menu_item->GetId(), text));
+  menu_item->Emit(MenuItemClickedEvent(menu_item->GetId()));
 }
 
 static void OnGtkMenuShow(GtkWidget* /*menu*/, gpointer user_data) {

src/platform/macos/menu_macos.mm

@@ -19,7 +19,7 @@
 static const void* kMenuIdKey = &kMenuIdKey;
 
 // Forward declarations - moved to global scope
-typedef void (^MenuItemClickedBlock)(nativeapi::MenuItemId item_id, const std::string& item_label);
+typedef void (^MenuItemClickedBlock)(nativeapi::MenuItemId item_id);
 typedef void (^MenuOpenedBlock)(nativeapi::MenuId menu_id);
 typedef void (^MenuClosedBlock)(nativeapi::MenuId menu_id);
 
@@ -125,14 +125,11 @@ - (void)menuItemClicked:(id)sender {
 
     // Call the block if it exists
     if (_clickedBlock) {
-      NSString* title = [menu_item title];
-      std::string item_label = title ? [title UTF8String] : "";
-
       // Get the MenuItemId from the menu item's associated object
       NSNumber* item_id_obj = objc_getAssociatedObject(menu_item, kMenuItemIdKey);
       if (item_id_obj) {
         nativeapi::MenuItemId item_id = [item_id_obj longValue];
-        _clickedBlock(item_id, item_label);
+        _clickedBlock(item_id);
       }
     }
   } @catch (NSException* exception) {
@@ -277,9 +274,9 @@ - (void)menuDidClose:(NSMenu*)menu {
   pimpl_->label_ = text.empty() ? std::nullopt : std::optional<std::string>(text);
 
   // 设置默认的 Block 处理器，直接发送事件
-  pimpl_->ns_menu_item_target_.clickedBlock = ^(MenuItemId item_id, const std::string& item_label) {
+  pimpl_->ns_menu_item_target_.clickedBlock = ^(MenuItemId item_id) {
     try {
-      Emit<MenuItemClickedEvent>(item_id, item_label);
+      Emit<MenuItemClickedEvent>(item_id);
     } catch (...) {
       // Protect against event emission exceptions
     }
@@ -294,9 +291,9 @@ - (void)menuDidClose:(NSMenu*)menu {
                            OBJC_ASSOCIATION_RETAIN_NONATOMIC);
 
   // 设置默认的 Block 处理器，直接发送事件
-  pimpl_->ns_menu_item_target_.clickedBlock = ^(MenuItemId item_id, const std::string& item_label) {
+  pimpl_->ns_menu_item_target_.clickedBlock = ^(MenuItemId item_id) {
     try {
-      Emit<MenuItemClickedEvent>(item_id, item_label);
+      Emit<MenuItemClickedEvent>(item_id);
     } catch (...) {
       // Protect against event emission exceptions
     }
@@ -547,8 +544,7 @@ - (void)menuDidClose:(NSMenu*)menu {
 
   // Call the block directly instead of going through target-action
   if (pimpl_->ns_menu_item_target_.clickedBlock) {
-    std::string itemText = pimpl_->label_.value_or("");
-    pimpl_->ns_menu_item_target_.clickedBlock(pimpl_->id_, itemText);
+    pimpl_->ns_menu_item_target_.clickedBlock(pimpl_->id_);
   }
   return true;
 }

src/platform/windows/menu_windows.cpp

@@ -284,8 +284,7 @@ bool MenuItem::Trigger() {
     return false;
 
   try {
-    std::string text = pimpl_->label_.has_value() ? pimpl_->label_.value() : "";
-    Emit<MenuItemClickedEvent>(id, text);
+    Emit<MenuItemClickedEvent>(pimpl_->id_);
   } catch (...) {
     // Protect against event emission exceptions
   }