Fix type conversions for menu and positioning APIs

Corrects type casting for menu item and menu IDs in C++ and Objective-C code, ensuring proper interoperability between native and C API layers. Also updates struct namespace usage in positioning strategy functions and clarifies a parameter name in menu.h documentation.

Author: lijy91

src/capi/menu_c.cpp

@@ -710,7 +710,7 @@ bool native_menu_remove_item_by_id(native_menu_t menu, native_menu_item_id_t ite
 
   try {
     auto menu_ptr = static_cast<Menu*>(menu);
-    return menu_ptr->RemoveItemById(item_id);
+    return menu_ptr->RemoveItemById(static_cast<MenuItemId>(item_id));
   } catch (...) {
     return false;
   }
@@ -795,7 +795,7 @@ native_menu_item_t native_menu_get_item_by_id(native_menu_t menu, native_menu_it
 
   try {
     auto menu_ptr = static_cast<Menu*>(menu);
-    auto item = menu_ptr->GetItemById(item_id);
+    auto item = menu_ptr->GetItemById(static_cast<MenuItemId>(item_id));
     return item ? static_cast<native_menu_item_t>(item.get()) : nullptr;
   } catch (...) {
     return nullptr;

src/capi/positioning_strategy_c.cpp

@@ -10,7 +10,7 @@ native_positioning_strategy_t native_positioning_strategy_absolute(const native_
     return nullptr;
   }
 
-  Point cpp_point{point->x, point->y};
+  nativeapi::Point cpp_point{point->x, point->y};
   PositioningStrategy* strategy = new PositioningStrategy(PositioningStrategy::Absolute(cpp_point));
   return static_cast<native_positioning_strategy_t>(strategy);
 }
@@ -26,10 +26,10 @@ native_positioning_strategy_t native_positioning_strategy_relative(const native_
     return nullptr;
   }
 
-  Rectangle cpp_rect{rect->x, rect->y, rect->width, rect->height};
-  Point cpp_offset{0, 0};
+  nativeapi::Rectangle cpp_rect{rect->x, rect->y, rect->width, rect->height};
+  nativeapi::Point cpp_offset{0, 0};
   if (offset) {
-    cpp_offset = Point{offset->x, offset->y};
+    cpp_offset = nativeapi::Point{offset->x, offset->y};
   }
 
   PositioningStrategy* strategy =

src/menu.h

@@ -184,7 +184,7 @@ class MenuItem : public EventEmitter<MenuEvent>, public NativeObjectProvider {
    *
    * Creates a menu item of the specified type with the given text.
    *
-   * @param text The display text for the menu item
+   * @param label The display text for the menu item
    * @param type The type of menu item to create
    *
    * @example

src/platform/macos/application_macos.mm

@@ -139,7 +139,7 @@ bool SetMenuBar(std::shared_ptr<Menu> menu) {
     }
 
     // Get the native menu handle
-    NSMenu* ns_menu = static_cast<NSMenu*>(menu->GetNativeObject());
+    NSMenu* ns_menu = (__bridge NSMenu*)(menu->GetNativeObject());
     if (!ns_menu) {
       return false;
     }

src/platform/macos/menu_macos.mm

@@ -128,7 +128,7 @@ - (void)menuItemClicked:(id)sender {
       // Get the MenuItemId from the menu item's associated object
       NSNumber* item_id_obj = objc_getAssociatedObject(menu_item, kMenuItemIdKey);
       if (item_id_obj) {
-        nativeapi::MenuItemId item_id = [item_id_obj longValue];
+        nativeapi::MenuItemId item_id = static_cast<nativeapi::MenuItemId>([item_id_obj longValue]);
         _clickedBlock(item_id);
       }
     }
@@ -151,7 +151,7 @@ - (void)menuWillOpen:(NSMenu*)menu {
       // Get the MenuId from the menu's associated object
       NSNumber* menu_id_obj = objc_getAssociatedObject(menu, kMenuIdKey);
       if (menu_id_obj) {
-        nativeapi::MenuId menu_id = [menu_id_obj longValue];
+        nativeapi::MenuId menu_id = static_cast<nativeapi::MenuId>([menu_id_obj longValue]);
         _openedBlock(menu_id);
       }
     }
@@ -170,7 +170,7 @@ - (void)menuDidClose:(NSMenu*)menu {
       // Get the MenuId from the menu's associated object
       NSNumber* menu_id_obj = objc_getAssociatedObject(menu, kMenuIdKey);
       if (menu_id_obj) {
-        nativeapi::MenuId menu_id = [menu_id_obj longValue];
+        nativeapi::MenuId menu_id = static_cast<nativeapi::MenuId>([menu_id_obj longValue]);
         _closedBlock(menu_id);
       }
     }