Removing Reader::read (#319)

Author: bismuth01

include/libp2p/basic/reader.hpp

@@ -20,20 +20,6 @@ namespace libp2p::basic {
 
     virtual ~Reader() = default;
 
-    /**
-     * @brief Reads exactly {@code} min(out.size(), bytes) {@nocode} bytes to
-     * the buffer.
-     * @param out output argument. Read data will be written to this buffer.
-     * @param bytes number of bytes to read
-     * @param cb callback with result of operation
-     *
-     * @note caller should maintain validity of an output buffer until callback
-     * is executed. It is usually done with either wrapping buffer as shared
-     * pointer, or having buffer as part of some class/struct, and using
-     * enable_shared_from_this()
-     */
-    virtual void read(BytesOut out, size_t bytes, ReadCallbackFunc cb) = 0;
-
     /**
      * @brief Reads up to {@code} min(out.size(), bytes) {@nocode} bytes to the
      * buffer.

include/libp2p/connection/loopback_stream.hpp

@@ -40,8 +40,6 @@ namespace libp2p::connection {
         const override;
 
    protected:
-    void read(BytesOut out, size_t bytes, ReadCallbackFunc cb) override;
-
     void readSome(BytesOut out, size_t bytes, ReadCallbackFunc cb) override;
 
     void writeSome(BytesIn in, size_t bytes, WriteCallbackFunc cb) override;

include/libp2p/layer/websocket/ssl_connection.hpp

@@ -32,7 +32,6 @@ namespace libp2p::connection {
     outcome::result<void> close() override;
     bool isClosed() const override;
 
-    void read(BytesOut out, size_t bytes, ReadCallbackFunc cb) override;
     void readSome(BytesOut out, size_t bytes, ReadCallbackFunc cb) override;
     void deferReadCallback(outcome::result<size_t> res,
                            ReadCallbackFunc cb) override;

include/libp2p/layer/websocket/ws_connection.hpp

@@ -68,8 +68,6 @@ namespace libp2p::connection {
 
     bool isClosed() const override;
 
-    void read(BytesOut out, size_t bytes, ReadCallbackFunc cb) override;
-
     void readSome(BytesOut out, size_t bytes, ReadCallbackFunc cb) override;
 
     void deferReadCallback(outcome::result<size_t> res,

include/libp2p/muxer/mplex/mplex_stream.hpp

@@ -50,8 +50,6 @@ namespace libp2p::connection {
 
     ~MplexStream() override = default;
 
-    void read(BytesOut out, size_t bytes, ReadCallbackFunc cb) override;
-
     void readSome(BytesOut out, size_t bytes, ReadCallbackFunc cb) override;
 
     void deferReadCallback(outcome::result<size_t> res,

include/libp2p/muxer/mplex/mplexed_connection.hpp

@@ -64,7 +64,6 @@ namespace libp2p::connection {
 
     /// usage of these four methods is highly not recommended or even forbidden:
     /// use stream over this connection instead
-    void read(BytesOut out, size_t bytes, ReadCallbackFunc cb) override;
     void readSome(BytesOut out, size_t bytes, ReadCallbackFunc cb) override;
     void writeSome(BytesIn in, size_t bytes, WriteCallbackFunc cb) override;
 

include/libp2p/muxer/yamux/yamux_stream.hpp

@@ -54,8 +54,6 @@ namespace libp2p::connection {
                 size_t maximum_window_size,
                 size_t write_queue_limit);
 
-    void read(BytesOut out, size_t bytes, ReadCallbackFunc cb) override;
-
     void readSome(BytesOut out, size_t bytes, ReadCallbackFunc cb) override;
 
     void deferReadCallback(outcome::result<size_t> res,

include/libp2p/muxer/yamux/yamuxed_connection.hpp

@@ -111,7 +111,6 @@ namespace libp2p::connection {
 
     /// usage of these four methods is highly not recommended or even forbidden:
     /// use stream over this connection instead
-    void read(BytesOut out, size_t bytes, ReadCallbackFunc cb) override;
     void readSome(BytesOut out, size_t bytes, ReadCallbackFunc cb) override;
     void writeSome(BytesIn in, size_t bytes, WriteCallbackFunc cb) override;
 

include/libp2p/security/noise/noise_connection.hpp

@@ -38,8 +38,6 @@ namespace libp2p::connection {
 
     outcome::result<void> close() override;
 
-    void read(BytesOut out, size_t bytes, ReadCallbackFunc cb) override;
-
     void readSome(BytesOut out, size_t bytes, ReadCallbackFunc cb) override;
 
     void deferReadCallback(outcome::result<size_t> res,

include/libp2p/security/plaintext/plaintext_connection.hpp

@@ -35,8 +35,6 @@ namespace libp2p::connection {
 
     outcome::result<multi::Multiaddress> remoteMultiaddr() override;
 
-    void read(BytesOut out, size_t bytes, ReadCallbackFunc cb) override;
-
     void readSome(BytesOut out, size_t bytes, ReadCallbackFunc cb) override;
 
     void deferReadCallback(outcome::result<size_t> res,