Remove size_t argument from readSome (#321)

* Remove size_t argument from readSome

* Removed unused function ambigousSize

Author: bismuth01

example/02-kademlia/rendezvous_chat.cpp

@@ -47,7 +47,6 @@ class Session : public std::enable_shared_from_this<Session> {
 
     stream_->readSome(
         *incoming_,
-        incoming_->size(),
         [self = shared_from_this()](outcome::result<size_t> result) {
           if (not result) {
             self->close();

include/libp2p/basic/read.hpp

@@ -18,7 +18,6 @@ namespace libp2p {
     // read some bytes
     reader->readSome(
         out,
-        out.size(),
         [weak{std::weak_ptr{reader}}, out, cb{std::move(cb)}](
             outcome::result<size_t> n_res) mutable {
           if (n_res.has_error()) {

include/libp2p/basic/reader.hpp

@@ -32,7 +32,7 @@ namespace libp2p::basic {
      * pointer, or having buffer as part of some class/struct, and using
      * enable_shared_from_this()
      */
-    virtual void readSome(BytesOut out, size_t bytes, ReadCallbackFunc cb) = 0;
+    virtual void readSome(BytesOut out, ReadCallbackFunc cb) = 0;
 
     /**
      * @brief Defers reporting result or error to callback to avoid reentrancy

include/libp2p/common/ambigous_size.hpp

@@ -68,7 +68,7 @@ namespace libp2p {
               boost::asio::mutable_buffer,
               MutableBufferSequence>::first(buffers)};
       impl->readSome(
-          asioBuffer(buffer), buffer.size(), wrapCb(std::forward<Cb>(cb)));
+          asioBuffer(buffer), wrapCb(std::forward<Cb>(cb)));
     }
 
     template <typename ConstBufferSequence, typename Cb>

include/libp2p/connection/as_asio_read_write.hpp

@@ -40,7 +40,7 @@ namespace libp2p::connection {
         const override;
 
    protected:
-    void readSome(BytesOut out, size_t bytes, ReadCallbackFunc cb) override;
+    void readSome(BytesOut out, ReadCallbackFunc cb) override;
 
     void writeSome(BytesIn in, WriteCallbackFunc cb) override;
 

include/libp2p/connection/loopback_stream.hpp

@@ -32,7 +32,7 @@ namespace libp2p::connection {
     outcome::result<void> close() override;
     bool isClosed() const override;
 
-    void readSome(BytesOut out, size_t bytes, ReadCallbackFunc cb) override;
+    void readSome(BytesOut out, ReadCallbackFunc cb) override;
     void deferReadCallback(outcome::result<size_t> res,
                            ReadCallbackFunc cb) override;
 

include/libp2p/layer/websocket/ssl_connection.hpp

@@ -68,7 +68,7 @@ namespace libp2p::connection {
 
     bool isClosed() const override;
 
-    void readSome(BytesOut out, size_t bytes, ReadCallbackFunc cb) override;
+    void readSome(BytesOut out, ReadCallbackFunc cb) override;
 
     void deferReadCallback(outcome::result<size_t> res,
                            ReadCallbackFunc cb) override;

include/libp2p/layer/websocket/ws_connection.hpp

@@ -50,7 +50,7 @@ namespace libp2p::connection {
 
     ~MplexStream() override = default;
 
-    void readSome(BytesOut out, size_t bytes, ReadCallbackFunc cb) override;
+    void readSome(BytesOut out, ReadCallbackFunc cb) override;
 
     void deferReadCallback(outcome::result<size_t> res,
                            ReadCallbackFunc cb) override;

include/libp2p/muxer/mplex/mplex_stream.hpp

@@ -64,7 +64,7 @@ namespace libp2p::connection {
 
     /// usage of these four methods is highly not recommended or even forbidden:
     /// use stream over this connection instead
-    void readSome(BytesOut out, size_t bytes, ReadCallbackFunc cb) override;
+    void readSome(BytesOut out, ReadCallbackFunc cb) override;
     void writeSome(BytesIn in, WriteCallbackFunc cb) override;
 
     void deferReadCallback(outcome::result<size_t> res,