Merge pull request #554 from libp2p/fix/553

Stebalien · web-flow · commit 4a4e60e00fe7 · 2020-04-05T22:38:15.000-07:00
fix incorrect error handling during provider record lookups
diff --git a/routing.go b/routing.go
@@ -606,7 +606,7 @@ func (dht *IpfsDHT) findProvidersAsyncRoutine(ctx context.Context, key multihash
 		},
 	)
 
-	if err != nil && ctx.Err() == nil {
+	if err == nil && ctx.Err() == nil {
 		dht.refreshRTIfNoShortcut(kb.ConvertKey(string(key)), lookupRes)
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -606,7 +606,7 @@ func (dht *IpfsDHT) findProvidersAsyncRoutine(ctx context.Context, key multihash`
`606`	`606`	`},`
`607`	`607`	`)`
`608`	`608`
`609`		`- if err != nil && ctx.Err() == nil {`
	`609`	`+ if err == nil && ctx.Err() == nil {`
`610`	`610`	`dht.refreshRTIfNoShortcut(kb.ConvertKey(string(key)), lookupRes)`
`611`	`611`	`}`
`612`	`612`	`}`