Merge pull request #390 from libp2p/fix/389

Stebalien · web-flow · commit 96d98235133f · 2019-09-04T17:06:20.000-07:00
metrics: fix memory leak
diff --git a/dht_net.go b/dht_net.go
@@ -114,7 +114,7 @@ func (dht *IpfsDHT) handleNewMessage(s network.Stream) bool {
 		timer.Reset(dhtStreamIdleTimeout)
 
 		startTime := time.Now()
-		ctx, _ = tag.New(
+		ctx, _ := tag.New(
 			ctx,
 			tag.Upsert(metrics.KeyMessageType, req.GetType().String()),
 		)
diff --git a/go.mod b/go.mod
@@ -27,3 +27,5 @@ require (
 	go.opencensus.io v0.21.0
 	golang.org/x/xerrors v0.0.0-20190513163551-3ee3066db522
 )
+
+go 1.12

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ func (dht *IpfsDHT) handleNewMessage(s network.Stream) bool {`
`114`	`114`	`timer.Reset(dhtStreamIdleTimeout)`
`115`	`115`
`116`	`116`	`startTime := time.Now()`
`117`		`- ctx, _ = tag.New(`
	`117`	`+ ctx, _ := tag.New(`
`118`	`118`	`ctx,`
`119`	`119`	`tag.Upsert(metrics.KeyMessageType, req.GetType().String()),`
`120`	`120`	`)`