feat: avoid repeated checksum calculations (#599)

arajasek · web-flow · commit f486808fbed1 · 2025-02-24T00:39:38.000+02:00
We don't need to recalculate the checksum for each peer.
diff --git a/gossipsub.go b/gossipsub.go
@@ -1196,11 +1196,11 @@ func (gs *GossipSubRouter) Publish(msg *Message) {
 			gs.lastpub[topic] = time.Now().UnixNano()
 		}
 
+		csum := computeChecksum(gs.p.idGen.ID(msg))
 		for p := range gmap {
-			mid := gs.p.idGen.ID(msg)
 			// Check if it has already received an IDONTWANT for the message.
 			// If so, don't send it to the peer
-			if _, ok := gs.unwanted[p][computeChecksum(mid)]; ok {
+			if _, ok := gs.unwanted[p][csum]; ok {
 				continue
 			}
 			tosend[p] = struct{}{}

Original file line number	Diff line number	Diff line change
`@@ -1196,11 +1196,11 @@ func (gs GossipSubRouter) Publish(msg Message) {`
`1196`	`1196`	`gs.lastpub[topic] = time.Now().UnixNano()`
`1197`	`1197`	`}`
`1198`	`1198`
	`1199`	`+ csum := computeChecksum(gs.p.idGen.ID(msg))`
`1199`	`1200`	`for p := range gmap {`
`1200`		`- mid := gs.p.idGen.ID(msg)`
`1201`	`1201`	`// Check if it has already received an IDONTWANT for the message.`
`1202`	`1202`	`// If so, don't send it to the peer`
`1203`		`- if _, ok := gs.unwanted[p][computeChecksum(mid)]; ok {`
	`1203`	`+ if _, ok := gs.unwanted[p][csum]; ok {`
`1204`	`1204`	`continue`
`1205`	`1205`	`}`
`1206`	`1206`	`tosend[p] = struct{}{}`