webtransport: close quic conn on dial error (#3104)

sukunrt · web-flow · commit d80b1da6689b · 2024-12-17T15:18:57.000-08:00
diff --git a/p2p/transport/webtransport/transport.go b/p2p/transport/webtransport/transport.go
@@ -175,10 +175,12 @@ func (t *transport) dialWithScope(ctx context.Context, raddr ma.Multiaddr, p pee
 	sconn, err := t.upgrade(ctx, sess, p, certHashes)
 	if err != nil {
 		sess.CloseWithError(1, "")
+		qconn.CloseWithError(1, "")
 		return nil, err
 	}
 	if t.gater != nil && !t.gater.InterceptSecured(network.DirOutbound, p, sconn) {
 		sess.CloseWithError(errorCodeConnectionGating, "")
+		qconn.CloseWithError(errorCodeConnectionGating, "")
 		return nil, fmt.Errorf("secured connection gated")
 	}
 	conn := newConn(t, sess, sconn, scope, qconn)

Original file line number	Diff line number	Diff line change
`@@ -175,10 +175,12 @@ func (t *transport) dialWithScope(ctx context.Context, raddr ma.Multiaddr, p pee`
`175`	`175`	`sconn, err := t.upgrade(ctx, sess, p, certHashes)`
`176`	`176`	`if err != nil {`
`177`	`177`	`sess.CloseWithError(1, "")`
	`178`	`+ qconn.CloseWithError(1, "")`
`178`	`179`	`return nil, err`
`179`	`180`	`}`
`180`	`181`	`if t.gater != nil && !t.gater.InterceptSecured(network.DirOutbound, p, sconn) {`
`181`	`182`	`sess.CloseWithError(errorCodeConnectionGating, "")`
	`183`	`+ qconn.CloseWithError(errorCodeConnectionGating, "")`
`182`	`184`	`return nil, fmt.Errorf("secured connection gated")`
`183`	`185`	`}`
`184`	`186`	`conn := newConn(t, sess, sconn, scope, qconn)`