ci: use go1.23, drop go1.21 (#2933)

sukunrt · web-flow · commit f535990da5e6 · 2024-08-21T13:42:36.000-07:00
diff --git a/.github/workflows/go-test.yml b/.github/workflows/go-test.yml
@@ -17,6 +17,6 @@ jobs:
   go-test:
     uses: ./.github/workflows/go-test-template.yml
     with:
-      go-versions: '["1.21.x", "1.22.x"]'
+      go-versions: '["1.22.x", "1.23.x"]'
     secrets:
       CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
diff --git a/p2p/net/nat/nat_test.go b/p2p/net/nat/nat_test.go
@@ -45,7 +45,8 @@ func TestAddMapping(t *testing.T) {
 	require.False(t, found, "didn't expect a port mapping for unmapped protocol")
 	mapped, found := nat.GetMapping("tcp", 10000)
 	require.True(t, found, "expected port mapping")
-	require.Equal(t, netip.AddrPortFrom(netip.AddrFrom4([4]byte{1, 2, 3, 4}), 1234), mapped)
+	addr, _ := netip.AddrFromSlice(net.IPv4(1, 2, 3, 4))
+	require.Equal(t, netip.AddrPortFrom(addr, 1234), mapped)
 }
 
 func TestRemoveMapping(t *testing.T) {

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,8 @@ func TestAddMapping(t *testing.T) {`
`45`	`45`	`require.False(t, found, "didn't expect a port mapping for unmapped protocol")`
`46`	`46`	`mapped, found := nat.GetMapping("tcp", 10000)`
`47`	`47`	`require.True(t, found, "expected port mapping")`
`48`		`- require.Equal(t, netip.AddrPortFrom(netip.AddrFrom4([4]byte{1, 2, 3, 4}), 1234), mapped)`
	`48`	`+ addr, _ := netip.AddrFromSlice(net.IPv4(1, 2, 3, 4))`
	`49`	`+ require.Equal(t, netip.AddrPortFrom(addr, 1234), mapped)`
`49`	`50`	`}`
`50`	`51`
`51`	`52`	`func TestRemoveMapping(t *testing.T) {`