fix: do not run webrtc cleanup on transport close (#2498)

The cleanup function from `node-datachannel` closes all open peer
connections/datachannels - if there are multiple transports/nodes
in the same process they will all be closed.

Author: achingbrain

packages/transport-webrtc/package.json

@@ -43,7 +43,6 @@
     "test:node": "aegir test -t node --cov",
     "test:chrome": "aegir test -t browser --cov",
     "test:firefox": "aegir test -t browser -- --browser firefox",
-    "test:electron-main": "aegir test -t electron-main",
     "lint": "aegir lint",
     "lint:fix": "aegir lint --fix",
     "clean": "aegir clean",

packages/transport-webrtc/src/private-to-private/transport.ts

@@ -6,7 +6,7 @@ import { WebRTC } from '@multiformats/multiaddr-matcher'
 import { codes } from '../error.js'
 import { WebRTCMultiaddrConnection } from '../maconn.js'
 import { DataChannelMuxerFactory } from '../muxer.js'
-import { cleanup, RTCPeerConnection } from '../webrtc/index.js'
+import { RTCPeerConnection } from '../webrtc/index.js'
 import { initiateConnection } from './initiate-connection.js'
 import { WebRTCPeerListener } from './listener.js'
 import { handleIncomingStream } from './signaling-stream-handler.js'
@@ -87,7 +87,6 @@ export class WebRTCTransport implements Transport, Startable {
 
   async stop (): Promise<void> {
     await this.components.registrar.unhandle(SIGNALING_PROTO_ID)
-    cleanup()
     this._started = false
   }
 

packages/transport-webrtc/src/webrtc/index.browser.ts

@@ -1,4 +1,3 @@
 export const RTCPeerConnection = globalThis.RTCPeerConnection
 export const RTCSessionDescription = globalThis.RTCSessionDescription
 export const RTCIceCandidate = globalThis.RTCIceCandidate
-export function cleanup (): void {}

packages/transport-webrtc/src/webrtc/index.ts

@@ -1,7 +1 @@
-import node from 'node-datachannel'
-
 export { RTCSessionDescription, RTCIceCandidate, RTCPeerConnection } from 'node-datachannel/polyfill'
-
-export function cleanup (): void {
-  node.cleanup()
-}