fix: allow importing the self key (#2700)

Because the keychain doesn't create keys, only accepts them, allow
importing the "self" key.

If the key already exists it will fail, and you still can't remove
or rename it.

Author: achingbrain

packages/keychain/src/keychain.ts

@@ -196,7 +196,7 @@ export class Keychain implements KeychainInterface {
   }
 
   async importKey (name: string, key: PrivateKey): Promise<KeyInfo> {
-    if (!validateKeyName(name) || name === 'self') {
+    if (!validateKeyName(name)) {
       await randomDelay()
       throw new InvalidParametersError(`Invalid key name '${name}'`)
     }

packages/keychain/test/keychain.spec.ts

@@ -174,13 +174,6 @@ describe('keychain', () => {
       const importedKey = await ks.importKey(keyName, exportedKey)
       expect(importedKey.id).to.eql(keyInfo.id)
     })
-
-    it('cannot create the "self" key', async () => {
-      const key = await generateKeyPair('Ed25519')
-
-      await expect(ks.importKey('self', key)).to.eventually.be.rejected
-        .with.property('name', 'InvalidParametersError')
-    })
   })
 
   describe('query', () => {
@@ -268,11 +261,6 @@ describe('keychain', () => {
         .with.property('name', 'InvalidParametersError')
     })
 
-    it('cannot create the "self" key', async () => {
-      await expect(ks.renameKey(rsaKeyName, 'self')).to.eventually.be.rejected
-        .with.property('name', 'InvalidParametersError')
-    })
-
     it('removes the existing key name', async () => {
       const key = await ks.renameKey(rsaKeyName, renamedRsaKeyName)
       expect(key).to.exist()