fix: pass digest to publicKeyFromProtobuf (#3014)

This with the changes from #3013 roughly doubles the throughput of loading RSA peers from the peer store which is a massive bottleneck when restarting the amino bootstrapper.

Before:

```
 % node benchmarks/load-peers.js
read all x 5.94 ops/sec ±1.37% (33 runs sampled)
```

After:

```
% node benchmarks/load-peers.js
read all x 12.43 ops/sec ±1.18% (63 runs sampled)
```

Author: achingbrain

packages/peer-store/benchmarks/load-peers.js

@@ -0,0 +1,54 @@
+/* eslint-disable no-console */
+import { generateKeyPair } from '@libp2p/crypto/keys'
+import { TypedEventEmitter } from '@libp2p/interface'
+import { defaultLogger } from '@libp2p/logger'
+import { peerIdFromPrivateKey } from '@libp2p/peer-id'
+import { multiaddr } from '@multiformats/multiaddr'
+import Benchmark from 'benchmark'
+import { MemoryDatastore } from 'datastore-core'
+import { persistentPeerStore } from '../dist/src/index.js'
+
+const privateKey = await generateKeyPair('Ed25519')
+const peerId = peerIdFromPrivateKey(privateKey)
+
+// simulate roughly full routing table
+const peers = 6_000
+const toAdd = await Promise.all(
+  new Array(peers).fill(0).map(async () => {
+    const privateKey = await generateKeyPair('RSA')
+    return peerIdFromPrivateKey(privateKey)
+  })
+)
+
+const datastore = new MemoryDatastore()
+const peerStore = persistentPeerStore({
+  peerId,
+  datastore,
+  events: new TypedEventEmitter(),
+  logger: defaultLogger()
+})
+
+for (const peer of toAdd) {
+  await peerStore.save(peer, {
+    multiaddrs: [
+      multiaddr('/ip4/123.123.123.123/tcp/1234')
+    ]
+  })
+}
+
+const main = function () {
+  const bench = new Benchmark('read all', {
+    defer: true,
+    fn: async function (deferred) {
+      await peerStore.all()
+      deferred.resolve()
+    }
+  })
+    .on('complete', function (stats) {
+      console.log(String(stats.currentTarget))
+    })
+
+  bench.run()
+}
+
+main()

packages/peer-store/package.json

@@ -76,6 +76,7 @@
     "@libp2p/logger": "^5.1.10",
     "@types/sinon": "^17.0.3",
     "aegir": "^45.1.1",
+    "benchmark": "^2.1.4",
     "datastore-core": "^10.0.2",
     "delay": "^6.0.0",
     "p-defer": "^4.0.1",

packages/peer-store/src/utils/bytes-to-peer.ts

@@ -1,17 +1,30 @@
 import { publicKeyFromProtobuf } from '@libp2p/crypto/keys'
 import { peerIdFromPublicKey } from '@libp2p/peer-id'
 import { multiaddr } from '@multiformats/multiaddr'
+import { base58btc } from 'multiformats/bases/base58'
+import * as Digest from 'multiformats/hashes/digest'
 import { Peer as PeerPB } from '../pb/peer.js'
 import type { PeerId, Peer, Tag } from '@libp2p/interface'
 
-export function bytesToPeer (peerId: PeerId, buf: Uint8Array): Peer {
-  const peer = PeerPB.decode(buf)
+function populatePublicKey (peerId: PeerId, protobuf: PeerPB): PeerId {
+  if (peerId.publicKey != null || protobuf.publicKey == null) {
+    return peerId
+  }
+
+  let digest: any
 
-  if (peer.publicKey != null && peerId.publicKey == null) {
-    const publicKey = publicKeyFromProtobuf(peer.publicKey)
-    peerId = peerIdFromPublicKey(publicKey)
+  if (peerId.type === 'RSA') {
+    // avoid hashing public key
+    const multihash = base58btc.decode(`z${peerId}`)
+    digest = Digest.decode(multihash)
   }
 
+  const publicKey = publicKeyFromProtobuf(protobuf.publicKey, digest)
+  return peerIdFromPublicKey(publicKey)
+}
+
+export function bytesToPeer (peerId: PeerId, buf: Uint8Array): Peer {
+  const peer = PeerPB.decode(buf)
   const tags = new Map<string, Tag>()
 
   // remove any expired tags
@@ -27,7 +40,7 @@ export function bytesToPeer (peerId: PeerId, buf: Uint8Array): Peer {
 
   return {
     ...peer,
-    id: peerId,
+    id: populatePublicKey(peerId, peer),
     addresses: peer.addresses.map(({ multiaddr: ma, isCertified }) => {
       return {
         multiaddr: multiaddr(ma),