fix: do not dial bootstrap nodes #3087
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the bootstrap module to only discover the bootstrap nodes but not dial them. Invidiual protocols that require bootstrapping (e.g. KAD-DHT) can then react to the disovery and choose to dial the peers. This cuts down on unecessary dials for lightweight nodes and brings the bootstrap module in line with other peer discovery mechanisms.
achingbrain
force-pushed
the
fix/do-not-dial-bootstrap-nodes
branch
from
052da78 to
fb73ed4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the bootstrap module to only discover the bootstrap nodes but not dial them.
Invidiual protocols that require bootstrapping (e.g. KAD-DHT) can then react to the disovery and choose to dial the peers.
This cuts down on unecessary dials for lightweight nodes and brings the bootstrap module in line with other peer discovery mechanisms.
Change checklist