Apply TotalTimeoutHandler only if duration seconds > 0 #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanBratanov
approved these changes
Aug 28, 2025
StefanBratanov
force-pushed
the
fix/limit
branch
from
d20c7d4 to
9ad50d8
Compare
# Conflicts: # libp2p/src/main/java/io/libp2p/protocol/circuit/CircuitHopProtocol.java
StefanBratanov
force-pushed
the
fix/limit
branch
from
bdd9745 to
5adfbe3
Compare
|
@StefanBratanov Hi, I forgot running spotlessApply so I re-committed after executing spotlessApply |
|
Hi @singlerr I fixed the merge conflict, but can you please revert the |
# Conflicts: # libp2p/src/main/java/io/libp2p/protocol/circuit/CircuitHopProtocol.java
|
Hi @StefanBratanov , all tasks done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to specs, in circuit relay v2, connection time limit must be applied only if duration limit is bigger than 0.
Therefore TotalTimeoutHandler should be added only if resv.durationSeconds > 0