Apply InboundTrafficLimitHandler only if max bytes > 0 #416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanBratanov
approved these changes
Aug 28, 2025
StefanBratanov
force-pushed
the
fix/datalimit
branch
from
7ac64e2 to
8301f3b
Compare
auto-merge was automatically disabled
August 28, 2025 13:57
Head branch was pushed to by a user without write access
|
@StefanBratanov Hi, I forgot running spotlessApply so I re-committed after executing spotlessApply |
Perfect! Thank you, will wait for the build to complete and will merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to specs, in circuit relay v2, connection data limit must be applied only if max bytes is bigger than 0.
Therefore InboundTrafficHandler should be added only if resv.maxBytes > 0