refactor: improve test structure in mDNS tests

Author: sumanjeet0012

tests/discovery/mdns/test_broadcaster.py

@@ -1,39 +1,40 @@
 """
 Unit tests for mDNS broadcaster component.
 """
-import socket
-import pytest
-from zeroconf import ServiceInfo, Zeroconf
+
+from zeroconf import Zeroconf
 
 from libp2p.discovery.mdns.broadcaster import PeerBroadcaster
 from libp2p.peer.id import ID
 
 
 class TestPeerBroadcaster:
-    """Basic unit tests for PeerBroadcaster."""
+    """Unit tests for PeerBroadcaster."""
 
     def test_broadcaster_initialization(self):
         """Test that broadcaster initializes correctly."""
         zeroconf = Zeroconf()
         service_type = "_p2p._udp.local."
         service_name = "test-peer._p2p._udp.local."
-        peer_id = "QmNnooDu7bfjPFoTZYxMNLWUQJyrVwtbZg5gBMjTezGAJN"  # String, not ID object
+        peer_id = (
+            "QmNnooDu7bfjPFoTZYxMNLWUQJyrVwtbZg5gBMjTezGAJN"  # String, not ID object
+        )
         port = 8000
 
         broadcaster = PeerBroadcaster(
             zeroconf=zeroconf,
             service_type=service_type,
             service_name=service_name,
             peer_id=peer_id,
-            port=port
+            port=port,
         )
 
         assert broadcaster.zeroconf == zeroconf
         assert broadcaster.service_type == service_type
         assert broadcaster.service_name == service_name
         assert broadcaster.peer_id == peer_id
         assert broadcaster.port == port
-        
+
         # Clean up
         zeroconf.close()
 
@@ -51,7 +52,7 @@ def test_broadcaster_service_creation(self):
             service_type=service_type,
             service_name=service_name,
             peer_id=peer_id,
-            port=port
+            port=port,
         )
 
         # Verify service was created and registered
@@ -62,7 +63,7 @@ def test_broadcaster_service_creation(self):
         assert service_info.port == port
         assert b"id" in service_info.properties
         assert service_info.properties[b"id"] == peer_id.encode()
-        
+
         # Clean up
         zeroconf.close()
 
@@ -80,11 +81,11 @@ def test_broadcaster_start_stop(self):
             service_type=service_type,
             service_name=service_name,
             peer_id=peer_id,
-            port=port
+            port=port,
         )
 
         # Service should be registered
         assert broadcaster.service_info is not None
-        
+
         # Clean up
         zeroconf.close()

tests/discovery/mdns/test_integration.py

@@ -1,18 +1,19 @@
 """
 Unit tests for mDNS listener component.
 """
+
 import socket
-import pytest
+
 from zeroconf import ServiceInfo, Zeroconf
 
+from libp2p.abc import Multiaddr
 from libp2p.discovery.mdns.listener import PeerListener
 from libp2p.peer.id import ID
 from libp2p.peer.peerstore import PeerStore
-from libp2p.abc import Multiaddr
 
 
 class TestPeerListener:
-    """Basic unit tests for PeerListener."""
+    """Unit tests for PeerListener."""
 
     def test_listener_initialization(self):
         """Test that listener initializes correctly."""
@@ -33,7 +34,7 @@ def test_listener_initialization(self):
         assert listener.service_type == service_type
         assert listener.service_name == service_name
         assert listener.discovered_services == {}
-        
+
         # Clean up
         listener.stop()
         zeroconf.close()
@@ -42,7 +43,7 @@ def test_listener_extract_peer_info_success(self):
         """Test successful PeerInfo extraction from ServiceInfo."""
         peerstore = PeerStore()
         zeroconf = Zeroconf()
-        
+
         listener = PeerListener(
             peerstore=peerstore,
             zeroconf=zeroconf,
@@ -51,10 +52,12 @@ def test_listener_extract_peer_info_success(self):
         )
 
         # Create sample service info
-        sample_peer_id = ID.from_base58("QmNnooDu7bfjPFoTZYxMNLWUQJyrVwtbZg5gBMjTezGAJN")
+        sample_peer_id = ID.from_base58(
+            "QmNnooDu7bfjPFoTZYxMNLWUQJyrVwtbZg5gBMjTezGAJN"
+        )
         hostname = socket.gethostname()
         local_ip = "192.168.1.100"
-        
+
         sample_service_info = ServiceInfo(
             type_="_p2p._udp.local.",
             name="test-peer._p2p._udp.local.",
@@ -70,10 +73,10 @@ def test_listener_extract_peer_info_success(self):
         assert isinstance(peer_info.peer_id, ID)
         assert len(peer_info.addrs) > 0
         assert all(isinstance(addr, Multiaddr) for addr in peer_info.addrs)
-        
+
         # Check that protocol is TCP since we always use TCP
         assert "/tcp/" in str(peer_info.addrs[0])
-        
+
         # Clean up
         listener.stop()
         zeroconf.close()
@@ -82,7 +85,7 @@ def test_listener_extract_peer_info_invalid_id(self):
         """Test PeerInfo extraction fails with invalid peer ID."""
         peerstore = PeerStore()
         zeroconf = Zeroconf()
-        
+
         listener = PeerListener(
             peerstore=peerstore,
             zeroconf=zeroconf,
@@ -93,7 +96,7 @@ def test_listener_extract_peer_info_invalid_id(self):
         # Create service info with invalid peer ID
         hostname = socket.gethostname()
         local_ip = "192.168.1.100"
-        
+
         service_info = ServiceInfo(
             type_="_p2p._udp.local.",
             name="invalid-peer._p2p._udp.local.",
@@ -105,7 +108,7 @@ def test_listener_extract_peer_info_invalid_id(self):
 
         peer_info = listener._extract_peer_info(service_info)
         assert peer_info is None
-        
+
         # Clean up
         listener.stop()
         zeroconf.close()