Skip to content

Commit b143c96

Browse files
authored
Merge pull request #803 from acul71/fix/fix-592-32bytes_prefix_go_fixme_comment
Remove FIXME about 32 bytes prefix in noise
2 parents cb11f07 + 678b920 commit b143c96

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

libp2p/security/noise/io.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@ class BaseNoiseMsgReadWriter(EncryptedMsgReadWriter):
4141
read_writer: NoisePacketReadWriter
4242
noise_state: NoiseState
4343

44-
# FIXME: This prefix is added in msg#3 in Go. Check whether it's a desired behavior.
44+
# NOTE: This prefix is added in msg#3 in Go.
45+
# Support in py-libp2p is available but not used
4546
prefix: bytes = b"\x00" * 32
4647

4748
def __init__(self, conn: IRawConnection, noise_state: NoiseState) -> None:

newsfragments/592.internal.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
remove FIXME comment since it's obsolete and 32-byte prefix support is there but not enabled by default

0 commit comments

Comments
 (0)