Skip to content

Commit fc9b289

Browse files
authored
Merge pull request #817 from acul71/fix/fix-816-remove-TODO-IK-patterns-in-noise
remove deprecated IK pattern TODO
2 parents 32e545d + 26d0ed2 commit fc9b289

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

libp2p/security/noise/transport.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,6 @@ class Transport(ISecureTransport):
2929
early_data: bytes | None
3030
with_noise_pipes: bool
3131

32-
# NOTE: Implementations that support Noise Pipes must decide whether to use
33-
# an XX or IK handshake based on whether they possess a cached static
34-
# Noise key for the remote peer.
35-
# TODO: A storage of seen noise static keys for pattern IK?
36-
3732
def __init__(
3833
self,
3934
libp2p_keypair: KeyPair,

newsfragments/816.internal.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
The TODO IK patterns in Noise has been deprecated in specs: https://github.com/libp2p/specs/tree/master/noise#handshake-pattern

0 commit comments

Comments
 (0)