Skip to content

Commit 09fa853

Browse files
authored
feat(quic): deprecate QUIC draft-29 version support
Deprecate support_draft_version field from QUIC protocol. resolves #3395 Pull-Request: #5786.
1 parent 9907a94 commit 09fa853

File tree

7 files changed

+13
-3
lines changed

7 files changed

+13
-3
lines changed

Cargo.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ libp2p-perf = { version = "0.4.0", path = "protocols/perf" }
9393
libp2p-ping = { version = "0.46.0", path = "protocols/ping" }
9494
libp2p-plaintext = { version = "0.43.0", path = "transports/plaintext" }
9595
libp2p-pnet = { version = "0.26.0", path = "transports/pnet" }
96-
libp2p-quic = { version = "0.12.0", path = "transports/quic" }
96+
libp2p-quic = { version = "0.12.1", path = "transports/quic" }
9797
libp2p-relay = { version = "0.20.0", path = "protocols/relay" }
9898
libp2p-rendezvous = { version = "0.16.0", path = "protocols/rendezvous" }
9999
libp2p-request-response = { version = "0.28.1", path = "protocols/request-response" }

transports/quic/CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
## 0.12.1
2+
3+
- Deprecate `Config::support_draft_29`.
4+
See [PR 5786](https://github.com/libp2p/rust-libp2p/pull/5786).
5+
16
## 0.12.0
27

38
<!-- Update to libp2p-core v0.43.0 -->

transports/quic/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "libp2p-quic"
3-
version = "0.12.0"
3+
version = "0.12.1"
44
authors = ["Parity Technologies <[email protected]>"]
55
edition = "2021"
66
rust-version = { workspace = true }

transports/quic/src/config.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ pub struct Config {
5959
/// If support for draft-29 is enabled servers support draft-29 and version 1 on all
6060
/// QUIC listening addresses.
6161
/// As client the version is chosen based on the remote's address.
62+
#[deprecated(note = "QUIC draft versions are no longer supported")]
6263
pub support_draft_29: bool,
6364

6465
/// TLS client config for the inner [`quinn::ClientConfig`].
@@ -72,6 +73,7 @@ pub struct Config {
7273
mtu_discovery_config: Option<MtuDiscoveryConfig>,
7374
}
7475

76+
#[expect(deprecated)]
7577
impl Config {
7678
/// Creates a new configuration object with default values.
7779
pub fn new(keypair: &libp2p_identity::Keypair) -> Self {
@@ -122,6 +124,7 @@ pub(crate) struct QuinnConfig {
122124
pub(crate) endpoint_config: quinn::EndpointConfig,
123125
}
124126

127+
#[expect(deprecated)]
125128
impl From<Config> for QuinnConfig {
126129
fn from(config: Config) -> QuinnConfig {
127130
let Config {

transports/quic/src/transport.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ pub struct GenTransport<P: Provider> {
8484
hole_punch_attempts: HashMap<SocketAddr, oneshot::Sender<Connecting>>,
8585
}
8686

87+
#[expect(deprecated)]
8788
impl<P: Provider> GenTransport<P> {
8889
/// Create a new [`GenTransport`] with the given [`Config`].
8990
pub fn new(config: Config) -> Self {

transports/quic/tests/smoke.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -295,6 +295,7 @@ fn concurrent_connections_and_streams_tokio() {
295295
.quickcheck(prop::<quic::tokio::Provider> as fn(_, _) -> _);
296296
}
297297

298+
#[expect(deprecated)]
298299
#[cfg(feature = "tokio")]
299300
#[tokio::test]
300301
async fn draft_29_support() {

0 commit comments

Comments
 (0)