fix(identity): drop rand_core feature in ed25519-dalek

This PR
- drops `rand_core` feature dependency from `ed25519-dalek` crate to unblock upgrading `rand` crate to `v0.9`.

Pull-Request: #6070.

Author: hanabi1224

Cargo.lock

@@ -84,7 +84,7 @@ libp2p-dns = { version = "0.44.0", path = "transports/dns" }
 libp2p-floodsub = { version = "0.46.1", path = "protocols/floodsub" }
 libp2p-gossipsub = { version = "0.49.0", path = "protocols/gossipsub" }
 libp2p-identify = { version = "0.47.0", path = "protocols/identify" }
-libp2p-identity = { version = "0.2.11" }
+libp2p-identity = { version = "0.2.12" }
 libp2p-kad = { version = "0.47.1", path = "protocols/kad" }
 libp2p-mdns = { version = "0.48.0", path = "protocols/mdns" }
 libp2p-memory-connection-limits = { version = "0.4.0", path = "misc/memory-connection-limits" }

Cargo.toml

@@ -1,3 +1,8 @@
+## 0.2.12
+
+- Avoid depending on the `rand_core` feature in `ed25519-dalek` crate.
+  See [PR 6070](https://github.com/libp2p/rust-libp2p/pull/6070)
+
 ## 0.2.11
 
 - Switch from `libsecp256` to `k256` for secp256k1 support.

identity/CHANGELOG.md

@@ -1,6 +1,6 @@
 [package]
 name = "libp2p-identity"
-version = "0.2.11"
+version = "0.2.12"
 edition = "2021" # MUST NOT inherit from workspace because we don't want to publish breaking changes to `libp2p-identity`.
 description = "Data structures and algorithms for identifying peers in libp2p."
 rust-version = "1.73.0" # MUST NOT inherit from workspace because we don't want to publish breaking changes to `libp2p-identity`.
@@ -37,7 +37,7 @@ ecdsa = ["dep:p256", "dep:zeroize", "dep:sec1", "dep:sha2", "dep:hkdf"]
 rsa = ["dep:ring", "dep:asn1_der", "dep:rand", "dep:zeroize"]
 ed25519 = ["dep:ed25519-dalek", "dep:zeroize", "dep:sha2", "dep:hkdf"]
 peerid = ["dep:multihash", "dep:bs58", "dep:thiserror", "dep:sha2", "dep:hkdf"]
-rand = ["dep:rand", "ed25519-dalek?/rand_core"]
+rand = ["dep:rand"]
 
 [dev-dependencies]
 quickcheck = { workspace = true }

identity/Cargo.toml

@@ -184,8 +184,11 @@ impl SecretKey {
     /// Generate a new Ed25519 secret key.
     #[cfg(feature = "rand")]
     pub fn generate() -> SecretKey {
-        let signing = ed25519::SigningKey::generate(&mut rand::rngs::OsRng);
-        SecretKey(signing.to_bytes())
+        use rand::RngCore as _;
+
+        let mut secret = ed25519::SecretKey::default();
+        rand::rngs::OsRng.fill_bytes(&mut secret);
+        SecretKey(secret)
     }
 
     /// Try to parse an Ed25519 secret key from a byte slice