fix(upnp): skip port mapping when an active port mapping is present

Author: RolandSherwin

protocols/upnp/CHANGELOG.md

@@ -1,3 +1,11 @@
+## 0.6.0
+
+- Skip port mapping when an active port mapping is present.
+  Previously, the behavior would skip creating new mappings if any mapping 
+  (active or inactive or pending) existed for the same port. Now it correctly only 
+  checks active mappings on the gateway.
+  See [PR XXXX](https://github.com/libp2p/rust-libp2p/pull/XXXX).
+
 ## 0.5.0
 
 - update igd-next to 0.16.1

protocols/upnp/src/behaviour.rs

@@ -270,15 +270,14 @@ impl NetworkBehaviour for Behaviour {
                     return;
                 };
 
-                if let Some((mapping, _state)) = self
-                    .mappings
-                    .iter()
-                    .find(|(mapping, _state)| mapping.internal_addr.port() == addr.port())
-                {
+                if let Some((mapping, _state)) = self.mappings.iter().find(|(mapping, state)| {
+                    matches!(state, MappingState::Active(_))
+                        && mapping.internal_addr.port() == addr.port()
+                }) {
                     tracing::debug!(
                         multiaddress=%multiaddr,
                         mapped_multiaddress=%mapping.multiaddr,
-                        "port from multiaddress is already being mapped"
+                        "port from multiaddress is already mapped on the gateway"
                     );
                     return;
                 }