Skip to content

Commit 4531898

Browse files
committed
address Elena's review
1 parent 4949c0e commit 4531898

File tree

5 files changed

+5
-9
lines changed

5 files changed

+5
-9
lines changed

Cargo.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ libp2p-identify = { version = "0.47.0", path = "protocols/identify" }
8787
libp2p-identity = { version = "0.2.12" }
8888
libp2p-kad = { version = "0.49.0", path = "protocols/kad" }
8989
libp2p-mdns = { version = "0.48.0", path = "protocols/mdns" }
90-
libp2p-memory-connection-limits = { version = "0.5.1", path = "misc/memory-connection-limits" }
90+
libp2p-memory-connection-limits = { version = "0.5.0", path = "misc/memory-connection-limits" }
9191
libp2p-metrics = { version = "0.17.0", path = "misc/metrics" }
9292
libp2p-mplex = { version = "0.43.1", path = "muxers/mplex" }
9393
libp2p-noise = { version = "0.46.1", path = "transports/noise" }

misc/memory-connection-limits/CHANGELOG.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
## 0.5.1
2-
3-
- fix limit checking according to documentation, limit should be reached not exceeded.
4-
See [PR XXXX](https://github.com/libp2p/rust-libp2p/pull/XXXX).
51
## 0.5.0
62

73
<!-- Update to libp2p-swarm v0.47.0 -->

misc/memory-connection-limits/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name = "libp2p-memory-connection-limits"
33
edition.workspace = true
44
rust-version = { workspace = true }
55
description = "Memory usage based connection limits for libp2p."
6-
version = "0.5.1"
6+
version = "0.5.0"
77
license = "MIT"
88
repository = "https://github.com/libp2p/rust-libp2p"
99
keywords = ["peer-to-peer", "libp2p", "networking"]

misc/memory-connection-limits/src/lib.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ const MAX_STALE_DURATION: Duration = Duration::from_millis(100);
8282
impl Behaviour {
8383
/// Sets the process memory usage threshold in absolute bytes.
8484
///
85-
/// New inbound and outbound connections will be denied when the threshold is reached.
85+
/// New inbound and outbound connections will be denied when the threshold is exceeded.
8686
pub fn with_max_bytes(max_allowed_bytes: usize) -> Self {
8787
Self {
8888
max_allowed_bytes,
@@ -95,7 +95,7 @@ impl Behaviour {
9595

9696
/// Sets the process memory usage threshold in the percentage of the total physical memory.
9797
///
98-
/// New inbound and outbound connections will be denied when the threshold is reached.
98+
/// New inbound and outbound connections will be denied when the threshold is exceeded.
9999
pub fn with_max_percentage(percentage: f64) -> Self {
100100
use sysinfo::{RefreshKind, System};
101101

0 commit comments

Comments
 (0)