chore: remove unreachable_patterns lint according to note

drHuangMHT · web-flow · commit 4ee0e07dc01b · 2025-03-20T00:42:14.000Z
Remove some `#[allow(unreachable_patterns)]` with #5650 merged. Pull-Request: #5933.
diff --git a/misc/allow-block-list/src/lib.rs b/misc/allow-block-list/src/lib.rs
@@ -277,8 +277,6 @@ where
         _: ConnectionId,
         event: THandlerOutEvent<Self>,
     ) {
-        // TODO: remove when Rust 1.82 is MSRV
-        #[allow(unreachable_patterns)]
         libp2p_core::util::unreachable(event)
     }
 
diff --git a/misc/connection-limits/src/lib.rs b/misc/connection-limits/src/lib.rs
@@ -390,8 +390,6 @@ impl NetworkBehaviour for Behaviour {
         _: ConnectionId,
         event: THandlerOutEvent<Self>,
     ) {
-        // TODO: remove when Rust 1.82 is MSRV
-        #[allow(unreachable_patterns)]
         libp2p_core::util::unreachable(event)
     }
 
@@ -722,8 +720,6 @@ mod tests {
             _connection_id: ConnectionId,
             event: THandlerOutEvent<Self>,
         ) {
-            // TODO: remove when Rust 1.82 is MSRV
-            #[allow(unreachable_patterns)]
             libp2p_core::util::unreachable(event)
         }
 
diff --git a/misc/memory-connection-limits/src/lib.rs b/misc/memory-connection-limits/src/lib.rs
@@ -196,8 +196,6 @@ impl NetworkBehaviour for Behaviour {
         _: ConnectionId,
         event: THandlerOutEvent<Self>,
     ) {
-        // TODO: remove when Rust 1.82 is MSRV
-        #[allow(unreachable_patterns)]
         libp2p_core::util::unreachable(event)
     }
 
diff --git a/misc/memory-connection-limits/tests/util/mod.rs b/misc/memory-connection-limits/tests/util/mod.rs
@@ -118,8 +118,6 @@ impl<const MEM_PENDING: usize, const MEM_ESTABLISHED: usize> NetworkBehaviour
         _: ConnectionId,
         event: THandlerOutEvent<Self>,
     ) {
-        // TODO: remove when Rust 1.82 is MSRV
-        #[allow(unreachable_patterns)]
         libp2p_core::util::unreachable(event)
     }
 
diff --git a/protocols/autonat/src/v2/client/handler/dial_back.rs b/protocols/autonat/src/v2/client/handler/dial_back.rs
@@ -76,8 +76,6 @@ impl ConnectionHandler for Handler {
                     tracing::warn!("Dial back request dropped, too many requests in flight");
                 }
             }
-            // TODO: remove when Rust 1.82 is MSRV
-            #[allow(unreachable_patterns)]
             ConnectionEvent::ListenUpgradeError(ListenUpgradeError { error, .. }) => {
                 libp2p_core::util::unreachable(error);
             }
diff --git a/protocols/autonat/src/v2/client/handler/dial_request.rs b/protocols/autonat/src/v2/client/handler/dial_request.rs
@@ -210,8 +210,6 @@ async fn start_stream_handle(
         .map_err(|e| match e {
             StreamUpgradeError::NegotiationFailed => Error::UnsupportedProtocol,
             StreamUpgradeError::Timeout => Error::Io(io::ErrorKind::TimedOut.into()),
-            // TODO: remove when Rust 1.82 is MSRV
-            #[allow(unreachable_patterns)]
             StreamUpgradeError::Apply(v) => libp2p_core::util::unreachable(v),
             StreamUpgradeError::Io(e) => Error::Io(e),
         })?;
diff --git a/protocols/autonat/src/v2/server/behaviour.rs b/protocols/autonat/src/v2/server/behaviour.rs
@@ -111,8 +111,6 @@ where
             Either::Left(Either::Left(Err(e))) => {
                 tracing::debug!("dial back error: {e:?}");
             }
-            // TODO: remove when Rust 1.82 is MSRV
-            #[allow(unreachable_patterns)]
             Either::Left(Either::Right(v)) => libp2p_core::util::unreachable(v),
             Either::Right(Either::Left(cmd)) => {
                 let addr = cmd.addr.clone();
diff --git a/protocols/autonat/src/v2/server/handler/dial_request.rs b/protocols/autonat/src/v2/server/handler/dial_request.rs
@@ -137,8 +137,6 @@ where
                     );
                 }
             }
-            // TODO: remove when Rust 1.82 is MSRV
-            #[allow(unreachable_patterns)]
             ConnectionEvent::ListenUpgradeError(ListenUpgradeError { error, .. }) => {
                 tracing::debug!("inbound request failed: {:?}", error);
             }
diff --git a/protocols/dcutr/src/behaviour.rs b/protocols/dcutr/src/behaviour.rs
@@ -319,8 +319,6 @@ impl NetworkBehaviour for Behaviour {
                     .or_default() += 1;
                 self.queued_events.push_back(ToSwarm::Dial { opts });
             }
-            // TODO: remove when Rust 1.82 is MSRV
-            #[allow(unreachable_patterns)]
             Either::Right(never) => libp2p_core::util::unreachable(never),
         };
     }
diff --git a/protocols/dcutr/src/handler/relayed.rs b/protocols/dcutr/src/handler/relayed.rs
@@ -117,8 +117,7 @@ impl Handler {
                 self.attempts += 1;
             }
             // A connection listener denies all incoming substreams, thus none can ever be fully
-            // negotiated. TODO: remove when Rust 1.82 is MSRV
-            #[allow(unreachable_patterns)]
+            // negotiated.
             future::Either::Right(output) => libp2p_core::util::unreachable(output),
         }
     }
@@ -154,8 +153,6 @@ impl Handler {
             <Self as ConnectionHandler>::InboundProtocol,
         >,
     ) {
-        // TODO: remove when Rust 1.82 is MSRV
-        #[allow(unreachable_patterns)]
         libp2p_core::util::unreachable(error.into_inner());
     }
 
@@ -167,8 +164,6 @@ impl Handler {
         >,
     ) {
         let error = match error {
-            // TODO: remove when Rust 1.82 is MSRV
-            #[allow(unreachable_patterns)]
             StreamUpgradeError::Apply(v) => libp2p_core::util::unreachable(v),
             StreamUpgradeError::NegotiationFailed => outbound::Error::Unsupported,
             StreamUpgradeError::Io(e) => outbound::Error::Io(e),
@@ -296,8 +291,6 @@ impl ConnectionHandler for Handler {
             ConnectionEvent::FullyNegotiatedOutbound(fully_negotiated_outbound) => {
                 self.on_fully_negotiated_outbound(fully_negotiated_outbound)
             }
-            // TODO: remove when Rust 1.82 is MSRV
-            #[allow(unreachable_patterns)]
             ConnectionEvent::ListenUpgradeError(listen_upgrade_error) => {
                 self.on_listen_upgrade_error(listen_upgrade_error)
             }
diff --git a/protocols/gossipsub/src/handler.rs b/protocols/gossipsub/src/handler.rs
@@ -516,8 +516,6 @@ impl ConnectionHandler for Handler {
                         ..
                     }) => match protocol {
                         Either::Left(protocol) => handler.on_fully_negotiated_inbound(protocol),
-                        // TODO: remove when Rust 1.82 is MSRV
-                        #[allow(unreachable_patterns)]
                         Either::Right(v) => libp2p_core::util::unreachable(v),
                     },
                     ConnectionEvent::FullyNegotiatedOutbound(fully_negotiated_outbound) => {
@@ -529,8 +527,6 @@ impl ConnectionHandler for Handler {
                     }) => {
                         tracing::debug!("Dial upgrade error: Protocol negotiation timeout");
                     }
-                    // TODO: remove when Rust 1.82 is MSRV
-                    #[allow(unreachable_patterns)]
                     ConnectionEvent::DialUpgradeError(DialUpgradeError {
                         error: StreamUpgradeError::Apply(e),
                         ..
diff --git a/protocols/kad/src/handler.rs b/protocols/kad/src/handler.rs
@@ -503,8 +503,6 @@ impl Handler {
         // is a `Infallible`.
         let protocol = match protocol {
             future::Either::Left(p) => p,
-            // TODO: remove when Rust 1.82 is MSRV
-            #[allow(unreachable_patterns)]
             future::Either::Right(p) => libp2p_core::util::unreachable(p),
         };
 
diff --git a/protocols/perf/src/client/handler.rs b/protocols/perf/src/client/handler.rs
@@ -109,8 +109,6 @@ impl ConnectionHandler for Handler {
         event: ConnectionEvent<Self::InboundProtocol, Self::OutboundProtocol>,
     ) {
         match event {
-            // TODO: remove when Rust 1.82 is MSRV
-            #[allow(unreachable_patterns)]
             ConnectionEvent::FullyNegotiatedInbound(FullyNegotiatedInbound {
                 protocol, ..
             }) => libp2p_core::util::unreachable(protocol),
@@ -143,8 +141,6 @@ impl ConnectionHandler for Handler {
                         result: Err(error.into()),
                     }));
             }
-            // TODO: remove when Rust 1.82 is MSRV
-            #[allow(unreachable_patterns)]
             ConnectionEvent::ListenUpgradeError(ListenUpgradeError { info: (), error }) => {
                 libp2p_core::util::unreachable(error)
             }
diff --git a/protocols/perf/src/server/handler.rs b/protocols/perf/src/server/handler.rs
@@ -75,8 +75,6 @@ impl ConnectionHandler for Handler {
     }
 
     fn on_behaviour_event(&mut self, v: Self::FromBehaviour) {
-        // TODO: remove when Rust 1.82 is MSRV
-        #[allow(unreachable_patterns)]
         libp2p_core::util::unreachable(v)
     }
 
@@ -97,22 +95,16 @@ impl ConnectionHandler for Handler {
                     tracing::warn!("Dropping inbound stream because we are at capacity");
                 }
             }
-            // TODO: remove when Rust 1.82 is MSRV
-            #[allow(unreachable_patterns)]
             ConnectionEvent::FullyNegotiatedOutbound(FullyNegotiatedOutbound { info, .. }) => {
                 libp2p_core::util::unreachable(info)
             }
 
-            // TODO: remove when Rust 1.82 is MSRV
-            #[allow(unreachable_patterns)]
             ConnectionEvent::DialUpgradeError(DialUpgradeError { info, .. }) => {
                 libp2p_core::util::unreachable(info)
             }
             ConnectionEvent::AddressChange(_)
             | ConnectionEvent::LocalProtocolsChange(_)
             | ConnectionEvent::RemoteProtocolsChange(_) => {}
-            // TODO: remove when Rust 1.82 is MSRV
-            #[allow(unreachable_patterns)]
             ConnectionEvent::ListenUpgradeError(ListenUpgradeError { info: (), error }) => {
                 libp2p_core::util::unreachable(error)
             }
diff --git a/protocols/ping/src/handler.rs b/protocols/ping/src/handler.rs
@@ -211,8 +211,6 @@ impl Handler {
                     "ping protocol negotiation timed out",
                 )),
             },
-            // TODO: remove when Rust 1.82 is MSRV
-            #[allow(unreachable_patterns)]
             StreamUpgradeError::Apply(e) => libp2p_core::util::unreachable(e),
             StreamUpgradeError::Io(e) => Failure::Other { error: Box::new(e) },
         };
diff --git a/protocols/relay/src/behaviour.rs b/protocols/relay/src/behaviour.rs
@@ -379,8 +379,6 @@ impl NetworkBehaviour for Behaviour {
     ) {
         let event = match event {
             Either::Left(e) => e,
-            // TODO: remove when Rust 1.82 is MSRV
-            #[allow(unreachable_patterns)]
             Either::Right(v) => libp2p_core::util::unreachable(v),
         };
 
diff --git a/protocols/relay/src/behaviour/handler.rs b/protocols/relay/src/behaviour/handler.rs
@@ -455,8 +455,6 @@ impl Handler {
             StreamUpgradeError::Timeout => outbound_stop::Error::Io(io::ErrorKind::TimedOut.into()),
             StreamUpgradeError::NegotiationFailed => outbound_stop::Error::Unsupported,
             StreamUpgradeError::Io(e) => outbound_stop::Error::Io(e),
-            // TODO: remove when Rust 1.82 is MSRV
-            #[allow(unreachable_patterns)]
             StreamUpgradeError::Apply(v) => libp2p_core::util::unreachable(v),
         };
 
diff --git a/protocols/relay/src/priv_client.rs b/protocols/relay/src/priv_client.rs
@@ -237,8 +237,6 @@ impl NetworkBehaviour for Behaviour {
     ) {
         let handler_event = match handler_event {
             Either::Left(e) => e,
-            // TODO: remove when Rust 1.82 is MSRV
-            #[allow(unreachable_patterns)]
             Either::Right(v) => libp2p_core::util::unreachable(v),
         };
 
diff --git a/protocols/relay/src/priv_client/handler.rs b/protocols/relay/src/priv_client/handler.rs
@@ -444,8 +444,6 @@ impl ConnectionHandler for Handler {
                     let _ = next.send(Ok(ev.protocol));
                 }
             }
-            // TODO: remove when Rust 1.82 is MSRV
-            #[allow(unreachable_patterns)]
             ConnectionEvent::ListenUpgradeError(ev) => libp2p_core::util::unreachable(ev.error),
             ConnectionEvent::DialUpgradeError(ev) => {
                 if let Some(next) = self.pending_streams.pop_front() {
@@ -584,8 +582,6 @@ fn into_reserve_error(e: StreamUpgradeError<Infallible>) -> outbound_hop::Reserv
         StreamUpgradeError::Timeout => {
             outbound_hop::ReserveError::Io(io::ErrorKind::TimedOut.into())
         }
-        // TODO: remove when Rust 1.82 is MSRV
-        #[allow(unreachable_patterns)]
         StreamUpgradeError::Apply(never) => libp2p_core::util::unreachable(never),
         StreamUpgradeError::NegotiationFailed => outbound_hop::ReserveError::Unsupported,
         StreamUpgradeError::Io(e) => outbound_hop::ReserveError::Io(e),
@@ -597,8 +593,6 @@ fn into_connect_error(e: StreamUpgradeError<Infallible>) -> outbound_hop::Connec
         StreamUpgradeError::Timeout => {
             outbound_hop::ConnectError::Io(io::ErrorKind::TimedOut.into())
         }
-        // TODO: remove when Rust 1.82 is MSRV
-        #[allow(unreachable_patterns)]
         StreamUpgradeError::Apply(never) => libp2p_core::util::unreachable(never),
         StreamUpgradeError::NegotiationFailed => outbound_hop::ConnectError::Unsupported,
         StreamUpgradeError::Io(e) => outbound_hop::ConnectError::Io(e),
diff --git a/protocols/request-response/src/cbor.rs b/protocols/request-response/src/cbor.rs
@@ -179,8 +179,6 @@ pub mod codec {
 
     fn decode_into_io_error(err: cbor4ii::serde::DecodeError<Infallible>) -> io::Error {
         match err {
-            // TODO: remove when Rust 1.82 is MSRV
-            #[allow(unreachable_patterns)]
             cbor4ii::serde::DecodeError::Core(DecodeError::Read(e)) => {
                 io::Error::new(io::ErrorKind::Other, e)
             }
diff --git a/protocols/request-response/src/handler.rs b/protocols/request-response/src/handler.rs
@@ -236,8 +236,6 @@ where
                 self.pending_events
                     .push_back(Event::OutboundUnsupportedProtocols(message.request_id));
             }
-            // TODO: remove when Rust 1.82 is MSRV
-            #[allow(unreachable_patterns)]
             StreamUpgradeError::Apply(e) => libp2p_core::util::unreachable(e),
             StreamUpgradeError::Io(e) => {
                 self.pending_events.push_back(Event::OutboundStreamFailed {
@@ -254,8 +252,6 @@ where
             <Self as ConnectionHandler>::InboundProtocol,
         >,
     ) {
-        // TODO: remove when Rust 1.82 is MSRV
-        #[allow(unreachable_patterns)]
         libp2p_core::util::unreachable(error)
     }
 }
@@ -479,8 +475,6 @@ where
             ConnectionEvent::DialUpgradeError(dial_upgrade_error) => {
                 self.on_dial_upgrade_error(dial_upgrade_error)
             }
-            // TODO: remove when Rust 1.82 is MSRV
-            #[allow(unreachable_patterns)]
             ConnectionEvent::ListenUpgradeError(listen_upgrade_error) => {
                 self.on_listen_upgrade_error(listen_upgrade_error)
             }
diff --git a/protocols/stream/src/handler.rs b/protocols/stream/src/handler.rs
@@ -89,8 +89,6 @@ impl ConnectionHandler for Handler {
     }
 
     fn on_behaviour_event(&mut self, event: Self::FromBehaviour) {
-        // TODO: remove when Rust 1.82 is MSRV
-        #[allow(unreachable_patterns)]
         libp2p_core::util::unreachable(event)
     }
 
@@ -133,8 +131,6 @@ impl ConnectionHandler for Handler {
                     swarm::StreamUpgradeError::Timeout => {
                         OpenStreamError::Io(io::Error::from(io::ErrorKind::TimedOut))
                     }
-                    // TODO: remove when Rust 1.82 is MSRV
-                    #[allow(unreachable_patterns)]
                     swarm::StreamUpgradeError::Apply(v) => libp2p_core::util::unreachable(v),
                     swarm::StreamUpgradeError::NegotiationFailed => {
                         OpenStreamError::UnsupportedProtocol(p)
diff --git a/swarm/src/behaviour/toggle.rs b/swarm/src/behaviour/toggle.rs
@@ -212,8 +212,6 @@ where
     ) {
         let out = match out {
             future::Either::Left(out) => out,
-            // TODO: remove when Rust 1.82 is MSRV
-            #[allow(unreachable_patterns)]
             future::Either::Right(v) => libp2p_core::util::unreachable(v),
         };
 
@@ -254,8 +252,6 @@ where
 
         let err = match err {
             Either::Left(e) => e,
-            // TODO: remove when Rust 1.82 is MSRV
-            #[allow(unreachable_patterns)]
             Either::Right(v) => libp2p_core::util::unreachable(v),
         };
 
diff --git a/swarm/src/connection.rs b/swarm/src/connection.rs
@@ -1203,23 +1203,17 @@ mod tests {
             event: ConnectionEvent<Self::InboundProtocol, Self::OutboundProtocol>,
         ) {
             match event {
-                // TODO: remove when Rust 1.82 is MSRV
-                #[allow(unreachable_patterns)]
                 ConnectionEvent::FullyNegotiatedInbound(FullyNegotiatedInbound {
                     protocol,
                     ..
                 }) => libp2p_core::util::unreachable(protocol),
-                // TODO: remove when Rust 1.82 is MSRV
-                #[allow(unreachable_patterns)]
                 ConnectionEvent::FullyNegotiatedOutbound(FullyNegotiatedOutbound {
                     protocol,
                     ..
                 }) => libp2p_core::util::unreachable(protocol),
                 ConnectionEvent::DialUpgradeError(DialUpgradeError { error, .. }) => {
                     self.error = Some(error)
                 }
-                // TODO: remove when Rust 1.82 is MSRV
-                #[allow(unreachable_patterns)]
                 ConnectionEvent::AddressChange(_)
                 | ConnectionEvent::ListenUpgradeError(_)
                 | ConnectionEvent::LocalProtocolsChange(_)
@@ -1228,8 +1222,6 @@ mod tests {
         }
 
         fn on_behaviour_event(&mut self, event: Self::FromBehaviour) {
-            // TODO: remove when Rust 1.82 is MSRV
-            #[allow(unreachable_patterns)]
             libp2p_core::util::unreachable(event)
         }
 
@@ -1292,8 +1284,6 @@ mod tests {
         }
 
         fn on_behaviour_event(&mut self, event: Self::FromBehaviour) {
-            // TODO: remove when Rust 1.82 is MSRV
-            #[allow(unreachable_patterns)]
             libp2p_core::util::unreachable(event)
         }
 
diff --git a/swarm/src/connection/pool/task.rs b/swarm/src/connection/pool/task.rs
@@ -106,8 +106,6 @@ pub(crate) async fn new_for_pending_outgoing_connection(
                 })
                 .await;
         }
-        // TODO: remove when Rust 1.82 is MSRV
-        #[allow(unreachable_patterns)]
         Either::Left((Ok(v), _)) => libp2p_core::util::unreachable(v),
         Either::Right((Ok((address, output, errors)), _)) => {
             let _ = events
@@ -146,8 +144,6 @@ pub(crate) async fn new_for_pending_incoming_connection<TFut>(
                 })
                 .await;
         }
-        // TODO: remove when Rust 1.82 is MSRV
-        #[allow(unreachable_patterns)]
         Either::Left((Ok(v), _)) => libp2p_core::util::unreachable(v),
         Either::Right((Ok(output), _)) => {
             let _ = events
diff --git a/swarm/src/dummy.rs b/swarm/src/dummy.rs
diff --git a/swarm/src/handler/pending.rs b/swarm/src/handler/pending.rs
diff --git a/swarm/tests/swarm_derive.rs b/swarm/tests/swarm_derive.rs
diff --git a/transports/quic/src/hole_punching.rs b/transports/quic/src/hole_punching.rs

Original file line number	Diff line number	Diff line change
`@@ -277,8 +277,6 @@ where`
`277`	`277`	`_: ConnectionId,`
`278`	`278`	`event: THandlerOutEvent<Self>,`
`279`	`279`	`) {`
`280`		`- // TODO: remove when Rust 1.82 is MSRV`
`281`		`- #[allow(unreachable_patterns)]`
`282`	`280`	`libp2p_core::util::unreachable(event)`
`283`	`281`	`}`
`284`	`282`
Original file line number	Diff line number	Diff line change
`@@ -196,8 +196,6 @@ impl NetworkBehaviour for Behaviour {`
`196`	`196`	`_: ConnectionId,`
`197`	`197`	`event: THandlerOutEvent<Self>,`
`198`	`198`	`) {`
`199`		`- // TODO: remove when Rust 1.82 is MSRV`
`200`		`- #[allow(unreachable_patterns)]`
`201`	`199`	`libp2p_core::util::unreachable(event)`
`202`	`200`	`}`
`203`	`201`
Original file line number	Diff line number	Diff line change
`@@ -118,8 +118,6 @@ impl<const MEM_PENDING: usize, const MEM_ESTABLISHED: usize> NetworkBehaviour`
`118`	`118`	`_: ConnectionId,`
`119`	`119`	`event: THandlerOutEvent<Self>,`
`120`	`120`	`) {`
`121`		`- // TODO: remove when Rust 1.82 is MSRV`
`122`		`- #[allow(unreachable_patterns)]`
`123`	`121`	`libp2p_core::util::unreachable(event)`
`124`	`122`	`}`
`125`	`123`
Original file line number	Diff line number	Diff line change
`@@ -76,8 +76,6 @@ impl ConnectionHandler for Handler {`
`76`	`76`	`tracing::warn!("Dial back request dropped, too many requests in flight");`
`77`	`77`	`}`
`78`	`78`	`}`
`79`		`- // TODO: remove when Rust 1.82 is MSRV`
`80`		`- #[allow(unreachable_patterns)]`
`81`	`79`	`ConnectionEvent::ListenUpgradeError(ListenUpgradeError { error, .. }) => {`
`82`	`80`	`libp2p_core::util::unreachable(error);`
`83`	`81`	`}`
Original file line number	Diff line number	Diff line change
`@@ -111,8 +111,6 @@ where`
`111`	`111`	`Either::Left(Either::Left(Err(e))) => {`
`112`	`112`	`tracing::debug!("dial back error: {e:?}");`
`113`	`113`	`}`
`114`		`- // TODO: remove when Rust 1.82 is MSRV`
`115`		`- #[allow(unreachable_patterns)]`
`116`	`114`	`Either::Left(Either::Right(v)) => libp2p_core::util::unreachable(v),`
`117`	`115`	`Either::Right(Either::Left(cmd)) => {`
`118`	`116`	`let addr = cmd.addr.clone();`
Original file line number	Diff line number	Diff line change
`@@ -137,8 +137,6 @@ where`
`137`	`137`	`);`
`138`	`138`	`}`
`139`	`139`	`}`
`140`		`- // TODO: remove when Rust 1.82 is MSRV`
`141`		`- #[allow(unreachable_patterns)]`
`142`	`140`	`ConnectionEvent::ListenUpgradeError(ListenUpgradeError { error, .. }) => {`
`143`	`141`	`tracing::debug!("inbound request failed: {:?}", error);`
`144`	`142`	`}`
Original file line number	Diff line number	Diff line change
`@@ -319,8 +319,6 @@ impl NetworkBehaviour for Behaviour {`
`319`	`319`	`.or_default() += 1;`
`320`	`320`	`self.queued_events.push_back(ToSwarm::Dial { opts });`
`321`	`321`	`}`
`322`		`- // TODO: remove when Rust 1.82 is MSRV`
`323`		`- #[allow(unreachable_patterns)]`
`324`	`322`	`Either::Right(never) => libp2p_core::util::unreachable(never),`
`325`	`323`	`};`
`326`	`324`	`}`
Original file line number	Diff line number	Diff line change
`@@ -117,8 +117,7 @@ impl Handler {`
`117`	`117`	`self.attempts += 1;`
`118`	`118`	`}`
`119`	`119`	`// A connection listener denies all incoming substreams, thus none can ever be fully`
`120`		`- // negotiated. TODO: remove when Rust 1.82 is MSRV`
`121`		`- #[allow(unreachable_patterns)]`
	`120`	`+ // negotiated.`
`122`	`121`	`future::Either::Right(output) => libp2p_core::util::unreachable(output),`
`123`	`122`	`}`
`124`	`123`	`}`
`@@ -154,8 +153,6 @@ impl Handler {`
`154`	`153`	`<Self as ConnectionHandler>::InboundProtocol,`
`155`	`154`	`>,`
`156`	`155`	`) {`
`157`		`- // TODO: remove when Rust 1.82 is MSRV`
`158`		`- #[allow(unreachable_patterns)]`
`159`	`156`	`libp2p_core::util::unreachable(error.into_inner());`
`160`	`157`	`}`
`161`	`158`
`@@ -167,8 +164,6 @@ impl Handler {`
`167`	`164`	`>,`
`168`	`165`	`) {`
`169`	`166`	`let error = match error {`
`170`		`- // TODO: remove when Rust 1.82 is MSRV`
`171`		`- #[allow(unreachable_patterns)]`
`172`	`167`	`StreamUpgradeError::Apply(v) => libp2p_core::util::unreachable(v),`
`173`	`168`	`StreamUpgradeError::NegotiationFailed => outbound::Error::Unsupported,`
`174`	`169`	`StreamUpgradeError::Io(e) => outbound::Error::Io(e),`
`@@ -296,8 +291,6 @@ impl ConnectionHandler for Handler {`
`296`	`291`	`ConnectionEvent::FullyNegotiatedOutbound(fully_negotiated_outbound) => {`
`297`	`292`	`self.on_fully_negotiated_outbound(fully_negotiated_outbound)`
`298`	`293`	`}`
`299`		`- // TODO: remove when Rust 1.82 is MSRV`
`300`		`- #[allow(unreachable_patterns)]`
`301`	`294`	`ConnectionEvent::ListenUpgradeError(listen_upgrade_error) => {`
`302`	`295`	`self.on_listen_upgrade_error(listen_upgrade_error)`
`303`	`296`	`}`