protocols/gossipsub: Emit gossip of all non empty topics (#2481)

divagant-martian · mxinden · web-flow · commit 78f59818568c · 2022-02-07T20:00:46.000+01:00
Co-authored-by: Max Inden &lt;mail@max-inden.de&gt;
diff --git a/protocols/gossipsub/CHANGELOG.md b/protocols/gossipsub/CHANGELOG.md
@@ -6,7 +6,10 @@
 
 - Move from `open-metrics-client` to `prometheus-client` (see [PR 2442]).
 
+- Emit gossip of all non empty topics (see [PR 2481]).
+
 [PR 2442]: https://github.com/libp2p/rust-libp2p/pull/2442
+[PR 2481]: https://github.com/libp2p/rust-libp2p/pull/2481
 
 # 0.35.0 [2022-01-27]
 
diff --git a/protocols/gossipsub/src/behaviour.rs b/protocols/gossipsub/src/behaviour.rs
@@ -2508,7 +2508,7 @@ where
         for (topic_hash, peers) in self.mesh.iter().chain(self.fanout.iter()) {
             let mut message_ids = self.mcache.get_gossip_message_ids(topic_hash);
             if message_ids.is_empty() {
-                return;
+                continue;
             }
 
             // if we are emitting more than GossipSubMaxIHaveLength message_ids, truncate the list

Original file line number	Diff line number	Diff line change
`@@ -2508,7 +2508,7 @@ where`
`2508`	`2508`	`for (topic_hash, peers) in self.mesh.iter().chain(self.fanout.iter()) {`
`2509`	`2509`	`let mut message_ids = self.mcache.get_gossip_message_ids(topic_hash);`
`2510`	`2510`	`if message_ids.is_empty() {`
`2511`		`- return;`
	`2511`	`+ continue;`
`2512`	`2512`	`}`
`2513`	`2513`
`2514`	`2514`	`// if we are emitting more than GossipSubMaxIHaveLength message_ids, truncate the list`