chore: address clippy lints for cargo 1.87.0-beta / clippy 0.1.87

Pull-Request: #5974.

Author: elenaf9

core/src/muxing/boxed.rs

@@ -85,7 +85,7 @@ fn into_io_error<E>(err: E) -> io::Error
 where
     E: Error + Send + Sync + 'static,
 {
-    io::Error::new(io::ErrorKind::Other, err)
+    io::Error::other(err)
 }
 
 impl StreamMuxerBox {

core/src/transport/boxed.rs

@@ -171,5 +171,5 @@ impl<O> FusedStream for Boxed<O> {
 }
 
 fn box_err<E: Error + Send + Sync + 'static>(e: E) -> io::Error {
-    io::Error::new(io::ErrorKind::Other, e)
+    io::Error::other(e)
 }

examples/browser-webrtc/src/lib.rs

@@ -104,5 +104,5 @@ impl Body {
 }
 
 fn js_error(msg: &str) -> JsError {
-    io::Error::new(io::ErrorKind::Other, msg).into()
+    io::Error::other(msg).into()
 }

examples/chat/src/main.rs

@@ -72,7 +72,7 @@ async fn main() -> Result<(), Box<dyn Error>> {
                 // signing)
                 .message_id_fn(message_id_fn) // content-address messages. No two messages of the same content will be propagated.
                 .build()
-                .map_err(|msg| io::Error::new(io::ErrorKind::Other, msg))?; // Temporary hack because `build` does not return a proper `std::error::Error`.
+                .map_err(io::Error::other)?; // Temporary hack because `build` does not return a proper `std::error::Error`.
 
             // build a gossipsub network behaviour
             let gossipsub = gossipsub::Behaviour::new(

examples/ipfs-private/src/main.rs

@@ -138,7 +138,7 @@ async fn main() -> Result<(), Box<dyn Error>> {
             let gossipsub_config = gossipsub::ConfigBuilder::default()
                 .max_transmit_size(262144)
                 .build()
-                .map_err(|msg| io::Error::new(io::ErrorKind::Other, msg))?; // Temporary hack because `build` does not return a proper `std::error::Error`.
+                .map_err(io::Error::other)?; // Temporary hack because `build` does not return a proper `std::error::Error`.
             Ok(MyBehaviour {
                 gossipsub: gossipsub::Behaviour::new(
                     gossipsub::MessageAuthenticity::Signed(key.clone()),

examples/stream/src/main.rs

@@ -148,7 +148,7 @@ async fn send(mut stream: Stream) -> io::Result<()> {
     stream.read_exact(&mut buf).await?;
 
     if bytes != buf {
-        return Err(io::Error::new(io::ErrorKind::Other, "incorrect echo"));
+        return Err(io::Error::other("incorrect echo"));
     }
 
     stream.close().await?;

hole-punching-tests/src/main.rs

@@ -333,10 +333,7 @@ impl FromStr for TransportProtocol {
         match mode {
             "tcp" => Ok(TransportProtocol::Tcp),
             "quic" => Ok(TransportProtocol::Quic),
-            _ => Err(io::Error::new(
-                io::ErrorKind::Other,
-                "Expected either 'tcp' or 'quic'",
-            )),
+            _ => Err(io::Error::other("Expected either 'tcp' or 'quic'")),
         }
     }
 }
@@ -353,10 +350,7 @@ impl FromStr for Mode {
         match mode {
             "dial" => Ok(Mode::Dial),
             "listen" => Ok(Mode::Listen),
-            _ => Err(io::Error::new(
-                io::ErrorKind::Other,
-                "Expected either 'dial' or 'listen'",
-            )),
+            _ => Err(io::Error::other("Expected either 'dial' or 'listen'")),
         }
     }
 }

misc/connection-limits/src/lib.rs

@@ -692,8 +692,7 @@ mod tests {
             _local_addr: &Multiaddr,
             _remote_addr: &Multiaddr,
         ) -> Result<THandler<Self>, ConnectionDenied> {
-            Err(ConnectionDenied::new(std::io::Error::new(
-                std::io::ErrorKind::Other,
+            Err(ConnectionDenied::new(std::io::Error::other(
                 "ConnectionDenier",
             )))
         }
@@ -706,8 +705,7 @@ mod tests {
             _role_override: Endpoint,
             _port_use: PortUse,
         ) -> Result<THandler<Self>, ConnectionDenied> {
-            Err(ConnectionDenied::new(std::io::Error::new(
-                std::io::ErrorKind::Other,
+            Err(ConnectionDenied::new(std::io::Error::other(
                 "ConnectionDenier",
             )))
         }

misc/multistream-select/src/negotiated.rs

@@ -368,7 +368,7 @@ impl From<NegotiationError> for io::Error {
         if let NegotiationError::ProtocolError(e) = err {
             return e.into();
         }
-        io::Error::new(io::ErrorKind::Other, err)
+        io::Error::other(err)
     }
 }
 

misc/quick-protobuf-codec/src/lib.rs

@@ -59,8 +59,7 @@ fn write_length(message: &impl MessageWrite, dst: &mut BytesMut) {
 /// Write the message itself to `dst`.
 fn write_message(item: &impl MessageWrite, dst: &mut BytesMut) -> io::Result<()> {
     let mut writer = Writer::new(BytesMutWriterBackend::new(dst));
-    item.write_message(&mut writer)
-        .map_err(|e| io::Error::new(io::ErrorKind::Other, e))?;
+    item.write_message(&mut writer).map_err(io::Error::other)?;
 
     Ok(())
 }