Skip to content

Commit f5b982a

Browse files
protocols/ping: Log remote PeerId instead of payload (#2608)
1 parent 2ad905f commit f5b982a

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

protocols/ping/src/lib.rs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,14 @@ impl NetworkBehaviour for Behaviour {
120120
_: &mut impl PollParameters,
121121
) -> Poll<NetworkBehaviourAction<Self::OutEvent, Self::ConnectionHandler>> {
122122
if let Some(e) = self.events.pop_back() {
123+
let Event { result, peer } = &e;
124+
125+
match result {
126+
Ok(Success::Ping { .. }) => log::debug!("Ping sent to {:?}", peer),
127+
Ok(Success::Pong) => log::debug!("Ping received from {:?}", peer),
128+
_ => {}
129+
}
130+
123131
Poll::Ready(NetworkBehaviourAction::GenerateEvent(e))
124132
} else {
125133
Poll::Pending

protocols/ping/src/protocol.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,12 +85,10 @@ where
8585
S: AsyncRead + AsyncWrite + Unpin,
8686
{
8787
let payload: [u8; PING_SIZE] = thread_rng().sample(distributions::Standard);
88-
log::debug!("Preparing ping payload {:?}", payload);
8988
stream.write_all(&payload).await?;
9089
stream.flush().await?;
9190
let started = Instant::now();
9291
let mut recv_payload = [0u8; PING_SIZE];
93-
log::debug!("Awaiting pong for {:?}", payload);
9492
stream.read_exact(&mut recv_payload).await?;
9593
if recv_payload == payload {
9694
Ok((stream, started.elapsed()))
@@ -108,9 +106,7 @@ where
108106
S: AsyncRead + AsyncWrite + Unpin,
109107
{
110108
let mut payload = [0u8; PING_SIZE];
111-
log::debug!("Waiting for ping ...");
112109
stream.read_exact(&mut payload).await?;
113-
log::debug!("Sending pong for {:?}", payload);
114110
stream.write_all(&payload).await?;
115111
stream.flush().await?;
116112
Ok(stream)

0 commit comments

Comments
 (0)