Move secp256k1 support into ecdsa
              
              #3785
            
            
              
  
  Closed
              
          
                  
                    
                      drHuangMHT
                    
                  
                
                  started this conversation in
                Ideas
              
            Replies: 1 comment 1 reply
-
| 
         As far as I know, https://docs.rs/libsecp256k1/0.7.1/libsecp256k1/ has received an audit where as  Not sure if the risk of moving from an audited to a non-audited crate is worth the benefit of a reduced dependency tree for those (what I'd consider legacy) applications that rely on   | 
  
Beta Was this translation helpful? Give feedback.
                  
                    1 reply
                  
                
            
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
        
    
Uh oh!
There was an error while loading. Please reload this page.
-
Crate
ecdsasupports keys generated withsecp256k1,secp256r1andsecp384r1. I think the move is safe because the spec only says the key should be encoded in pkcs#8 format. Changing implementation does not change how the key is encoded, so there shouldn't be any compatibility issue. Plus, we usep256for dealing with ECDSA keys, which only supportssecp256r1curve, and we uselibsecp256k1for secp256k1 keys. Both crates don't support encoding keys into pkcs#8 format, which is the problem we want to address in #3681.Beta Was this translation helpful? Give feedback.
All reactions